Repository navigation
Watch every table anchor, not just the index root - #1360
Merged
Merged
Conversation
skip-changelog: test-only
skip-changelog: internal watcher plumbing, no observable change
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1232. Step 2 of 4. Stacked on #1349 (base
claude/1232-anchor-plumbing); PR 3 stacks on this.The watcher watches the index root plus every table anchor outside it, so a change under an anchor reaches its tables. No observable change yet: nothing sets an anchor.
Changelog / Migrations
skip-changelog:on a commit)E2E Verification
[[table]], pluson_file_query_test.py, since the change adds multi-root watching):capture_collision_test.py,declared_table_name_test.py,extension_package_test.py,query_contract_test.py,plugin_discovery_test.py,sigint_interrupt_test.py,fanout_test.py,use_case_transcripts_test.py,plugin_extension_discovery_test.py,on_file_query_test.py-- 29 passed. Command:testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'just e2e-attest-ts: passcargo test --test watcher --test table_anchor_watch --libwithulimit -n 65536; the watcher tests also hit the host inotify-instance limit when run in parallelpackages/ts/e2e-attestations/claude-1232-multi-watch.jsonandpackages/python/e2e-attestations/claude-1232-multi-watch.jsonwrittenRed commit: fb95168, CI run 37402936031 (
table_anchor_watchreturns[]).Red commit: fb95168 (
tests/table_anchor_watch.rs). CI run 37410724475 (pushed alone on a throwaway branch against #1349):a_file_created_under_an_anchor_outside_the_root_emits_an_insertandthe_root_and_an_outside_anchor_are_both_watchedfail on their assertions (table_anchor_watch.rs:58 and :85), not a build error.