Skip to content

Watch every table anchor, not just the index root - #1360

Merged
thekevinbot merged 12 commits into
mainfrom
claude/1232-multi-watch
Oct 6, 2026
Merged

thekevinbot merged 12 commits into
mainfrom
claude/1232-multi-watch

Conversation

@thekevinbot

@thekevinbot thekevinbot commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Part of #1232. Step 2 of 4. Stacked on #1349 (base claude/1232-anchor-plumbing); PR 3 stacks on this.

The watcher watches the index root plus every table anchor outside it, so a change under an anchor reaches its tables. No observable change yet: nothing sets an anchor.

Changelog / Migrations

  • No fragments: no observable change (skip-changelog: on a commit)

E2E Verification

  • Python SDK e2e: pass after merging main. Impacted files only (every e2e file declaring a [[table]], plus on_file_query_test.py, since the change adds multi-root watching): capture_collision_test.py, declared_table_name_test.py, extension_package_test.py, query_contract_test.py, plugin_discovery_test.py, sigint_interrupt_test.py, fanout_test.py, use_case_transcripts_test.py, plugin_extension_discovery_test.py, on_file_query_test.py -- 29 passed. Command: testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'
  • TypeScript: just e2e-attest-ts: pass
  • Rust: cargo test --test watcher --test table_anchor_watch --lib with ulimit -n 65536; the watcher tests also hit the host inotify-instance limit when run in parallel
  • Receipts packages/ts/e2e-attestations/claude-1232-multi-watch.json and packages/python/e2e-attestations/claude-1232-multi-watch.json written

Red commit: fb95168, CI run 37402936031 (table_anchor_watch returns []).

Red commit: fb95168 (tests/table_anchor_watch.rs). CI run 37410724475 (pushed alone on a throwaway branch against #1349): a_file_created_under_an_anchor_outside_the_root_emits_an_insert and the_root_and_an_outside_anchor_are_both_watched fail on their assertions (table_anchor_watch.rs:58 and :85), not a build error.

Base automatically changed from claude/1232-anchor-plumbing to main October 6, 2026 16:22
@thekevinbot
thekevinbot enabled auto-merge October 6, 2026 16:25
@thekevinbot
thekevinbot merged commit e2ed30f into main Oct 6, 2026
83 checks passed
@thekevinbot
thekevinbot deleted the claude/1232-multi-watch branch October 6, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant