Repository navigation
fix: a spelled dot component no longer opens dot directories above it - #1356
Merged
Merged
Conversation
4 of 6 tasks
test: glob speed of light with dot-named entries (stacked on #1356)
…dot component's mismatch
thekevinbot
enabled auto-merge
October 6, 2026 11:43
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1351
'./**/.*'returned dotfiles inside dot-named directories (.cache/.z). In bash, and per docs/reference/path-tables.md,**never enters a dot-named directory; only a component that spells it at that depth does.The fix: a
Component::DotNamefor components spelled with a leading.. In the walk's state machine, neither**nor a plain component consumes a dot-named entry, so the walk prunes a dot-named directory unless a dot component at that depth matches it.E2E Verification
tests/e2e/), 58 passed, after merging main (Test one-level glob listings at speed of light #1317)cargo test --workspace --features cli: pass, except the watcher tests that are flaky locally on main (server_*_directory_moved_*,get_events_streams_mutation_events,watch_*)packages/python/e2e-attestations/<branch>.jsonwritten (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonwritten (just e2e-attest-ts)just e2e-attest-python,just e2e-attest-ts,cargo test --workspace --features cli --no-fail-fast./**/.*gives.x,a/.y;./.cache/**/.*gives.cache/.z;./**/.cache/*.mdgives.cache/m.md,a/.cache/m.md. Each matchesbash -O globstar.