Repository navigation
One compiler behind config [[table]] globs and path-tables - #1348
Merged
Merged
Conversation
7 tasks done
thekevinscott
enabled auto-merge
October 6, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1258. First of a stack of PRs; based on
main. The next PRs are stacked on this one.Config
[[table]]globs are compiled by the samePathGlobcompiler as path-tables, so the bash brace rules ({1..3}ranges) read the same on both surfaces. No other behavior change. The walk,.gitignore, dot,{name},node_modulesand symlink rules follow in the stacked PRs.Red commit: 8ce860d, CI run 37395351491 (
config_glob_parityfails: config side returns[], path-table returnsf1.md f2.md f3.md).Changelog / Migrations
packages/{rust,python,ts}/changelog.d/packages/{rust,python,ts}/migrations.d/E2E Verification
packages/python/e2e-attestations/claude-1258-one-pattern.json. Impacted files only (every e2e file declaring a[[table]], since the change is config-table glob matching):capture_collision_test.py,declared_table_name_test.py,extension_package_test.py,query_contract_test.py,plugin_discovery_test.py,sigint_interrupt_test.py,fanout_test.py,use_case_transcripts_test.py,plugin_extension_discovery_test.py-- 26 passedToo many open filesfrom the shared host, unrelated to this changepackages/ts/e2e-attestations/claude-1258-one-pattern.jsonwrittenjust e2e-attest-ts,testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'