Skip to content

One compiler behind config [[table]] globs and path-tables - #1348

Merged
thekevinscott merged 7 commits into
mainfrom
claude/1258-one-pattern
Oct 6, 2026
Merged

thekevinscott merged 7 commits into
mainfrom
claude/1258-one-pattern

Conversation

@thekevinbot

@thekevinbot thekevinbot commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Refs #1258. First of a stack of PRs; based on main. The next PRs are stacked on this one.

Config [[table]] globs are compiled by the same PathGlob compiler as path-tables, so the bash brace rules ({1..3} ranges) read the same on both surfaces. No other behavior change. The walk, .gitignore, dot, {name}, node_modules and symlink rules follow in the stacked PRs.

Red commit: 8ce860d, CI run 37395351491 (config_glob_parity fails: config side returns [], path-table returns f1.md f2.md f3.md).

Changelog / Migrations

  • Changelog fragment added under packages/{rust,python,ts}/changelog.d/
  • Migration fragment with the same slug added under packages/{rust,python,ts}/migrations.d/

E2E Verification

  • Ran e2e suites locally for every affected SDK
  • Python SDK e2e: pass after merging main (Test one-level glob listings at speed of light #1317), receipt packages/python/e2e-attestations/claude-1258-one-pattern.json. Impacted files only (every e2e file declaring a [[table]], since the change is config-table glob matching): capture_collision_test.py, declared_table_name_test.py, extension_package_test.py, query_contract_test.py, plugin_discovery_test.py, sigint_interrupt_test.py, fanout_test.py, use_case_transcripts_test.py, plugin_extension_discovery_test.py -- 26 passed
  • TypeScript SDK e2e: pass
  • Rust core e2e: no new failures; the watcher tests fail locally with Too many open files from the shared host, unrelated to this change
  • packages/ts/e2e-attestations/claude-1258-one-pattern.json written
  • Command(s) run: just e2e-attest-ts, testing-conventions e2e attest 'uv run python -m pytest tests/e2e/<impacted files> -x -q'
  • Result summary: TypeScript and Python e2e attested.

@thekevinscott
thekevinscott merged commit f366eb7 into main Oct 6, 2026
99 of 102 checks passed
@thekevinscott
thekevinscott deleted the claude/1258-one-pattern branch October 6, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants