Repository navigation
Scan node_modules when a glob names it after a wildcard - #1276
Merged
Merged
Conversation
thekevinscott
enabled auto-merge
October 5, 2026 18:21
…les-named # Conflicts: # docs/reference/path-tables.md
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A path-table pattern that names
node_modulesafter a glob component ('./**/node_modules/**','./*/node_modules/*/*') now scans it. Before, only anode_modulesin the literal prefix counted as naming it. The approved divergence in #1255 is "node_modulesskipped unless the path names it", and a literalnode_modulescomponent anywhere in the pattern names it. Patterns that don't name it ('./**','./**/*.js') still skip it.How it works:
PathTable::default_ignoresdrops the built-in**/node_modules/**rule for a table whose glob has a literalnode_modulescomponent.Dbnow keeps only the configuredignorepatterns and adds each table's defaults when it creates the table. A configurednode_modulesignore still applies. The stat form and the--on-fileform both go through this path.Compared with
bash -O globstar -O nullglob(dotglob off) on a fixture withnode_modules/top.js,node_modules/pkg/index.js,pkg/node_modules/dep/i.jsandsrc/a.js, under--no-ignore. dirsql now lists the same files bash does, leaving out directories, for'./**/node_modules/**','./**/node_modules/*/*','./*/node_modules/*/*','./node_modules/*'and'./pkg/node_modules/**'. For'./**'and'./**/*.js'it still returns onlysrc/a.js, which is the approved divergence.Fixes #1271
E2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)uv run maturin develop --release,just e2e-attest-python,just e2e-attest-ts,cargo test --workspace --features cli,just preflightwithout the mutation gateChangelog / Migrations
<root>/<pkg>/changelog.d/for each changed package<root>/<pkg>/migrations.d/for each changed packageMerge with main
maindid not compile its unit tests after #1277 and #1278 merged: #1277's two newWalk { .. }test initializers lacked #1278'sin_repofield. The merge addsin_repo: falseto both, and re-pins thesrc/scanner.rsmutation waivers intesting-conventions.tomlto the lines they guard after #1277 shifted them.