Repository navigation
Give the walk-prune scanner tests the in_repo field - #1302
Closed
thekevinbot wants to merge 4 commits into
Closed
thekevinbot wants to merge 4 commits into
thekevinbot wants to merge 4 commits into
Conversation
skip-changelog: test-only change; no observable behavior
Collaborator
Author
|
Superseded: #1276 merged the same in_repo fix to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1301
#1277 and #1278 merged one after the other. #1277 added two
Walk { .. }initializers in thescanner.rstests, and #1278 added thein_repofield, so main's Rust tests stopped compiling (E0063). This setsin_repo: falsein both, which is what a walk withgitignore: falsestarts with.Only test code changes, so there's no red commit: main itself is the red (Rust CI on 4a2833b).
E2E Verification
just e2e-attest-python: 40 passedjust e2e-attest-ts: passedjust preflight(no mutation): 0 failingcargo test -p dirsql --features cli --lib scanner: 56 passed