Repository navigation
One glob rule for [[table]] glob and [dirsql] ignore: * stops at / - #1250
Merged
Merged
Conversation
A lone * stops at /, ** crosses it, on [[table]] glob and [dirsql] ignore
as it already does on path-tables. One matcher test per measured row of
the fixture table, plus the default ignores, a {name} placeholder, and
two from_config cases over a nested fixture.
…eparator One glob rule on every surface. A lone * or ? stops at /, ** crosses it, on declared-table globs and ignore patterns as it already did on path-tables. Patterns written with ** are unchanged, so the built-in **/node_modules/** and **/.git/** skips still apply at every depth. The config, path-tables and SDK references state the rule; each package carries a changelog and a migration fragment for the ** rewrite.
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1223 (part 2: one glob rule on every surface).
[[table]] globand[dirsql] ignorecompiled withglobsetdefaults, so*and?crossed/; path-tables already compiled withliteral_separator(true). All threeGlob::newsites inpackages/rust/src/matcher.rs(table globs, the ignore set, the<dir>/**ignore-dir set) now go through oneGlobBuilder::new(p).literal_separator(true).build().**is unchanged, so the built-in**/node_modules/**/**/.git/**skips and any**/*.extglob behave as before. A{name}placeholder matches exactly one segment.No other
Glob::newsite exists:vtab.rs,parsed_vtab.rsandvtab_scaffold.rsalready route throughscanner::compile_glob.Breaking: a config that relied on
*crossing/must write**(migration fragments per package). Parity: the matcher is shared core, so all three SDKs change together; no drift,PARITY.mdunchanged.Tests
matcher.rs: one test per config-glob and ignore row of the measured table (*,folder,folder/*,folder/**,**/*.md,**/*, ignorefolder/*, ignore*), the default ignores at every depth, the<dir>/*/**ignore-dir case,?not crossing/, and a{name}placeholder matching one segment only.tests/from_config.rs: nested fixture (root.json,folder/a.json,folder/sub/b.json) --glob = "*.json"ingestsroot.jsononly;ignore = ["folder/*"]+glob = "**/*.json"yieldsfolder/sub/b.jsonandroot.json.Unit tests/Integration testsfailed on exactly those assertions (7 matcher + 2 from_config) before the implementation was pushed.Hand-check
cargo build --release --features cli, run from a 7-file fixture (root.md,root.txt,folder/a.md,folder/a.txt,folder/sub/b.md,folder/sub/b.txt,sibling/c.md) with the config outside the tree,SELECT count(*) FROM t -c cfg.toml:glob = "*"glob = "folder"glob = "folder/*"glob = "folder/**"glob = "**/*.md"glob = "**/*"ignore = ["folder/*"]+glob = "**/*"ignore = ["folder/*"]+FROM './'ignore = ["*"]+glob = "**/*"ignore = ["*"]+FROM './'glob = "{name}/*.md"folder/a.md,sibling/c.md)Changelog / Migrations
<root>/<pkg>/changelog.d/for each changed package:packages/rust,packages/python,packages/ts(2026-10-03-one-glob-rule-for-config-globs.md)<root>/<pkg>/migrations.d/for each of the three packages (the*->**rewrite)E2E Verification
40 passed, 2 xfailed)6 files, 18 tests)cargo test --workspace --features cli, 0 failures)packages/python/e2e-attestations/claude-1223-config-glob-rule.jsonreceipt written (just e2e-attest-python)packages/ts/e2e-attestations/claude-1223-config-glob-rule.jsonreceipt written (just e2e-attest-ts)cargo test --workspace --features cli;cargo build --release --features cli;cd packages/python && uv run maturin develop --release;cd packages/ts && pnpm build;just e2e-attest-python;just e2e-attest-ts;just preflightjust preflightreported only the two e2e-verify receipt gates failing before attestation, clean after.