Repository navigation
feat(core): a path-table directory name is one level, like ls - #1251
Merged
Merged
Conversation
thekevinscott
enabled auto-merge
October 5, 2026 00:12
A directory path-table expands to <dir>/* instead of <dir>/**/*, so './' and './docs' list one level and '**' is the only way to descend. Hints for the retired files table and the hookless-table config error point at './**'. Docs, default config, PARITY, and per-package changelog and migration fragments follow.
thekevinbot
force-pushed
the
claude/1223-dir-one-level
branch
from
October 5, 2026 00:28
6c11b71 to
58da7e3
Compare
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1223
A path-table directory name means one level, like
ls docs.'./','./docs'and'./docs/'list the files directly inside that directory;*matches one level and**any depth, so the recursive spellings are'./**'and'./docs/**'. The same rule applies to absolute,../and~/path-tables and to the--on-fileform. Thefiles-table and hookless-[[table]]hints now point atFROM './**'.Spec rows and where each is pinned:
'./'a_bare_dot_slash_lists_the_index_root_one_level_deepa_bare_dot_slash_lists_the_working_directory_one_level_deep'./docs','./docs/'docs/a_relative_directory_lists_one_level,..._with_a_trailing_slash_...a_directory_path_lists_one_level'./*''./'an_explicit_star_is_the_same_as_the_bare_dot_slash'./**'a_double_star_scans_every_depth'./docs/**/*.md'docs/a_relative_recursive_glob_is_used_as_writtena_recursive_glob_under_a_directory_is_used_as_written'./notes/today.md'a_relative_single_file_roots_at_its_parentAbsolute,
../,~/, filesystem root, and Windows drive forms each have a one-level unit test.--on-file:path_table_parser.rs::a_parsed_directory_path_table_lists_one_level. Watch mode: path-tables have no watcher and re-scan per statement, so the two-levels-down case is pinned as a live re-scan test (path_table_globs.rs::a_file_created_two_levels_down_does_not_join_a_one_level_table);handle_upsertinlib.rsis the declared-table watcher path and is part 2's surface.Red commit
526e138went red in CI onUnit testsfor the asserted reason (left: "**/*",right: "*") plus the hint assertions.Every test, doc, README passage,
default_config.tomlcomment, and binding test that wroteFROM './'meaning recursive now writes'./**'. Headline one-liners over flat fixtures were left alone.docs/reference/path-tables.md"Writing the path" is rewritten; the "Hidden files" section is untouched (#1249). Nothing underchangelog.d/ormigrations.d/was edited; new fragments only.Rebase onto main (after #1236, #1239, #1248, #1250)
path_table.rsnow roots the walk at the literal prefix (#1236), so a./docstable isroot=/index/docs, glob=*, path_prefix=docsrather than the pre-rebaseglob=docs/*. The one-level rule lands insplit_targetasDIRECTORY_GLOB = "*"in place ofRECURSIVE_GLOB = "**/*"; the prefix walk and the parallel walk are untouched. Main'san_explicit_star_is_left_non_recursiveis subsumed byan_explicit_star_is_the_same_as_the_bare_dot_slashand dropped. Indocs/reference/path-tables.mdmain's glob-rule sentence in "Skip rules" is kept with its example spelled'./**'.Post-rebase hand-check,
cargo build -p dirsql --features cli --release, run from a fixture ofa.txt,d1/b.txt,d1/c.txt,d1/d2/e.txt,d1/d2/f.txt:count(*)'./''./d1''./**''./*''./d1/*.txt'SELECT path FROM './d1/**'d1/b.txt..d1/d2/f.txt(index-root-relative)Hand-check
cargo build --release --features cli, then the binary against a fixture ofroot.md,folder/a.md,folder/sub/b.md,sibling/c.md,notes/today.md:'./'root.md'./folder'folder/a.md'./folder/'folder/a.md'./*'root.md'./**''./folder/**/*.md'folder/a.md,folder/sub/b.md'./notes/today.md'notes/today.md'/abs/folder'.../folder/a.md'/abs/folder/**'--on-fileover'./folder'/'./folder/**'SELECT 1 FROM filesno such table: files; did you mean FROM './**'?Changelog / Migrations
packages/rust/changelog.d/2026-10-03-path-table-directory-one-level.mdpackages/python/changelog.d/2026-10-03-path-table-directory-one-level.mdpackages/ts/changelog.d/2026-10-03-path-table-directory-one-level.mdpackages/rust/migrations.d/2026-10-03-path-table-directory-one-level.mdpackages/python/migrations.d/2026-10-03-path-table-directory-one-level.mdpackages/ts/migrations.d/2026-10-03-path-table-directory-one-level.mdPARITY.md
Row added: "Path-table directory name is one level;
**descends (#1223)" -- Y/Y/Y. No drift: the rule lives in the shared core and both bindings pin it (path_table_test.py::it_lists_one_level_for_a_directory_name,path-table.test.ts"lists one level for a directory name").E2E Verification
cargo test --workspace --features cli, 63 test binaries, 0 failed)packages/python/e2e-attestations/claude-1223-dir-one-level.jsonreceipt written (just e2e-attest-python)packages/ts/e2e-attestations/claude-1223-dir-one-level.jsonreceipt written (just e2e-attest-ts)cargo test --workspace --features cli,cargo build -p dirsql --features cli --release,uv run maturin develop --release(packages/python),pnpm build(packages/ts),just e2e-attest-python,just e2e-attest-ts,just preflightjust preflightreported 0 failing pair(s), 3 skipped