Skip to content

test(python): make notebook speed-of-light xfail non-strict #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thekevinbot wants to merge 2 commits into from
Closed

test(python): make notebook speed-of-light xfail non-strict #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01584ef
test(python): make notebook speed-of-light xfail non-strict
thekevinbot Oct 2, 2026
b3a7ed5
e2e attestation for claude/1221-notebook-xfail-nonstrict
thekevinbot Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/python/e2e-attestations/claude-1221-notebook-xfail-nonstrict.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"command": "just test-e2e",
"ran_at": 1790954117,
"exit_code": 0,
"commit": "01584efd421785ae68f0fe3b9e92e80a164404a2",
"branch": "claude/1221-notebook-xfail-nonstrict"
}
2 changes: 1 addition & 1 deletion packages/python/tests/e2e/use_case_notebook_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def root(tmp_path):
shutil.rmtree(tree, ignore_errors=True)

@pytest.mark.xfail(
strict=True,
strict=False,
reason="ingesting the parser's JSON rows is slower than a second interpreter's json.load and sort",
)
def it_matches_native_rows_within_the_bar(root):
Expand Down
Loading