Repository navigation
Port fluent-app and fluent-test-utils to gpui_platform - #15
Open
thedancingdeveloper wants to merge 1 commit into
Open
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
gpui::Application::new() is gone from the vendored upstream gpui. FluentApp::run now starts the app through gpui_platform::application(), and fluent-test-utils exposes the same constructor as application(). The window API the chrome and title bar use is unchanged: WindowOptions, TitlebarOptions, WindowDecorations, ResizeEdge, HitboxBehavior and the window methods (start_window_resize, start_window_move, zoom, minimise, remove, decorations, hitbox, cursor style, app id, close handler, title) keep their signatures, so chrome.rs, title_bar.rs and assets.rs are untouched. AssetSource and the test-support contexts are likewise unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14 (
wi-1428-port-fluent-layout). Do not merge until #14 and everything beneath it has landed; this branch contains the whole stack.WI-1429.
gpui::Application::new()is gone from the vendored upstream gpui, soFluentApp::runnow starts the app throughgpui_platform::application(), andfluent-test-utilsexposes the same constructor asapplication().What did not change
The window API the chrome and title bar use is unchanged, so
chrome.rs,title_bar.rsandassets.rsare untouched:WindowOptions,TitlebarOptions,WindowDecorations::Client,ResizeEdge,HitboxBehaviorwindow_decorations,insert_hitbox,start_window_resize,start_window_move,zoom_window,minimize_window,remove_window,set_cursor_style,set_app_id,on_window_should_close,set_window_titleAssetSourceTestAppContext/VisualTestContextandadd_window_view(still behind gpui'stest-supportfeature)API break
fluent-test-utilsgains a publicapplication() -> gpui::Application. Nothing else in the two crates' public API changes:FluentAppstill builds and runs the same way.Not covered
examples/screenshots/src/main.rscallsgpui::Application::new()directly and will not compile on this branch. It is outside the two crates this port covers; the examples that go throughFluentApppick the fix up automatically.Operator check
This host has no display, so client-side decorations were not exercised. Please confirm
examples/hello_worldopens a frameless window and that move, resize, zoom and minimise work on both Wayland and X11.Gates (Linux,
--offline)cargo check -p fluent-app -p fluent-test-utils --tests— cleancargo test -p fluent-app -p fluent-test-utils --lib— 7 passed, 0 failedcargo clippy -p fluent-app -p fluent-test-utils --tests --no-deps -- -D warnings— clean (--no-depsbecause the vendoredschedulercrate fails clippy on its own, unrelated to this change)