Repository navigation
Port the examples to the vendored gpui - #16
Open
thedancingdeveloper wants to merge 1 commit into
Open
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
The vendored gpui removed Application::new(); the other examples go through FluentApp, which WI-1429 already moved. Only screenshots constructed the application directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
examples/*onto the vendored gpui, stacked on #15 (WI-1429).gallery,demo_app,hello_world,widgetsandformall launch throughFluentApp::run, which Port fluent-app and fluent-test-utils to gpui_platform #15 already moved togpui_platform::application(), so they needed no source change.demo_app's key bindings (KeyBinding::new) andsurface_blur_layer(a plainHslacolour) both still resolve against the vendored gpui.screenshotswas the only example callingApplication::new()directly. It now callsgpui_platform::application(), matching the drift report (docs/gpui-api-drift.md). ItsWindowOptionsfields (window_bounds,titlebar,window_decorations,focus,show) are unchanged in the vendored gpui.Stacked on #15. Do not merge until #15 is merged, and not before review.
Gates (Linux, this host)
cargo check --workspace --examples --offline— green.cargo clippy -p <crate> --all-targets --no-deps -- -D warnings— 0 errors for fluent-core, fluent-primitives, fluent-layout, fluent-ribbon, fluent-app, fluent-test-utils, demo_app, form, gallery, hello_world, screenshots, widgets.--no-depsis required: the vendored zed crates fail-D warningson their own (ztracingcfgs,scheduler,http_client), which is outside this item.cargo test --workspace --offline --tests(vendored gpui crates excluded) — all green. The two doctest failures ingpui_macrosare pre-existing in the vendored tree.Operator check
This host has no display, so nothing was run. On a machine with a display:
Look for: each opens a window themed with the Fluent dark palette and renders without a panic.
hello_worldshows a counter with Increment and Reset buttons.galleryandwidgetsshow the component galleries.formshows the form.demo_appshows the demo shell; Ctrl-K opens the command palette and Ctrl-Shift-L / Ctrl-Shift-D switch themes.screenshots buttonopens a 1000x600 window titled "FluentGUI-Screenshots" showing the button variants and writes/tmp/.fluent-screenshot-readyafter the first frame.Regenerating screenshot baselines is WI-1431 and is deliberately not done here.