Repository navigation
Port fluent-layout to the vendored upstream gpui (WI-1428) - #14
Open
thedancingdeveloper wants to merge 1 commit into
Open
thedancingdeveloper wants to merge 1 commit into
thedancingdeveloper wants to merge 1 commit into
Conversation
Three changes, all forced by the vendored gpui: Window::focus takes &mut App, AsyncApp::update returns its value instead of a Result, and gpui::Corner is gone so Popover anchors with gpui::Anchor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #13 (
wi-1427-port-fluent-ribbon). Do not merge until #13 lands; this PR's base is that branch, notgpui-upstream.Ports
crates/fluent-layoutto the vendored zed gpui. Three changes, each forced by the vendored gpui:Window::focusnow takes&mut App. The four call sites (command palette, context menu, menu bar, menu button) pass thecxalready in scope.AsyncApp::updatereturns its value directly instead of aResult. The toast timeout's.ok()is gone; the dismiss still runs.gpui::Corneris removed.Popover::anchornow takesgpui::Anchor, and the menu button anchors its popup atAnchor::TopLeft.No other behaviour changes. The element-scale and font pre-warm patches were not needed.
Public API
Popover::anchortakesgpui::Anchorinstead of the removedgpui::Corner. The four variants (TopLeft/TopRight/BottomLeft/BottomRight) keep their names, so call sites that named a variant only change the type. Nothing else in the public API moved.Operator check
None. This is a compile-level port; nothing here needs a visual check.
Gates (Linux)
cargo check -p fluent-layout --all-targets— cleancargo test -p fluent-layout— 37 passed, 0 failed (1 doc-test ignored, as before)cargo clippy -p fluent-layout --all-targets --no-deps -- -D warnings— clean.--no-depsbecause the vendoredztracingcrate fails-D warningson its ownunexpected_cfglint, which is outside this crate.WI-1428.