Skip to content

Removed deprecated testing dependency #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdavalos7 merged 1 commit into from
Aug 7, 2026
Merged

Removed deprecated testing dependency #7146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tensorboard/webapp/angular/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,12 +347,12 @@ tf_ts_library(
deps = ["@npm//@angular/platform-browser"],
)

# This is a dummy rule used as a @angular/platform-browser-dynamic/testing dependency.
# This is not a replacement for @angular/platform-browser-dynamic dependency.
# This is a dummy rule used as a @angular/platform-browser/testing dependency.
# This is not a replacement for @angular/platform-browser dependency.
tf_ts_library(
name = "expect_angular_platform_browser_dynamic_testing",
name = "expect_angular_platform_browser_testing",
srcs = [],
deps = ["@npm//@angular/platform-browser-dynamic"],
deps = ["@npm//@angular/platform-browser"],
)

# This is a dummy rule used as a @angular/cdk/drag_drop dependency.
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/app_routing/views/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ tf_ts_library(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_testing",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/app_routing:app_root",
"//tensorboard/webapp/app_routing:location",
Expand Down
1 change: 0 additions & 1 deletion tensorboard/webapp/app_routing/views/router_outlet_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
} from '@angular/core';
import {TestBed} from '@angular/core/testing';
import {By} from '@angular/platform-browser';
import {BrowserDynamicTestingModule} from '@angular/platform-browser-dynamic/testing';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
import {Store} from '@ngrx/store';
import {MockStore} from '@ngrx/store/testing';
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/metrics/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ tf_ts_library(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_testing",
"//tensorboard/webapp/feature_flag",
"//tensorboard/webapp/metrics/store:metrics_initial_state_provider",
"//tensorboard/webapp/metrics/store:types",
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/runs/views/runs_table/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_material_sort",
"//tensorboard/webapp/angular:expect_angular_material_table",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_testing",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/app_routing:testing",
"//tensorboard/webapp/app_routing:types",
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/settings/_views/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_testing",
"//tensorboard/webapp/angular:expect_ngrx_store_testing",
"//tensorboard/webapp/settings:testing",
"//tensorboard/webapp/settings/_redux",
Expand Down
1 change: 0 additions & 1 deletion tensorboard/webapp/settings/_views/settings_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {MatCheckboxModule} from '@angular/material/checkbox';
import {MatDialogModule} from '@angular/material/dialog';
import {MatInputModule} from '@angular/material/input';
import {By} from '@angular/platform-browser';
import {BrowserDynamicTestingModule} from '@angular/platform-browser-dynamic/testing';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
import {Store} from '@ngrx/store';
import {MockStore, provideMockStore} from '@ngrx/store/testing';
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/testing/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ tf_ts_library(
],
deps = [
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_testing",
"@npm//@angular/core",
"@npm//@angular/localize",
],
)
Expand Down Expand Up @@ -107,7 +108,6 @@ tf_ng_module(
"//tensorboard/webapp:reducer_config",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/angular:expect_angular_platform_browser_dynamic_testing",
"//tensorboard/webapp/app_routing",
"//tensorboard/webapp/app_routing:route_config",
"//tensorboard/webapp/app_routing:route_registry",
Expand Down
10 changes: 5 additions & 5 deletions tensorboard/webapp/testing/initialize_testbed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ import {NgModule, provideZoneChangeDetection} from '@angular/core';
import {TestBed} from '@angular/core/testing';
import '@angular/localize/init';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';
BrowserTestingModule,
platformBrowserTesting,
} from '@angular/platform-browser/testing';

@NgModule({
providers: [provideZoneChangeDetection()],
})
class ZoneChangeDetectionTestingModule {}

TestBed.initTestEnvironment(
[BrowserDynamicTestingModule, ZoneChangeDetectionTestingModule],
platformBrowserDynamicTesting()
[BrowserTestingModule, ZoneChangeDetectionTestingModule],
platformBrowserTesting()
);
Loading