Removed deprecated testing dependency - #7146
Merged
Merged
Conversation
…internally is not supported anymore.
cdavalos7
marked this pull request as ready for review
August 7, 2026 00:25
arcra
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
@angular/platform-browser-dynamic/testingwas deprecated in Angular 21. TheOSS build still accepts it, but the internal build no longer does, so it has to
go.
The internal build also reported a strictDeps error on
initialize_testbed.ts:Technical description of changes
testing/initialize_testbed.ts: removed the 2 deprecated symbols for their@angular/platform-browser/testingequivalents, dropped dynamic fromplatformBrowserDynamicTestingandBrowserDynamicTestingModule.angular/BUILD: renameexpect_angular_platform_browser_dynamic_testingexpect_angular_platform_browser_testing, now pointing at@npm//@angular/platform-browser. Its four consumer BUILD files were updated to match.testing/BUILD: add@npm//@angular/coretoinitialize_testbed, which is thestrictDepsfix.Some references were removed rather than renamed, because they were not used:
settings/_views/settings_test.tsandapp_routing/views/router_outlet_test.tsimportedBrowserDynamicTestingModulewithout ever using it, so the import lines were removed.integration_test_moduleintesting/BUILDdeclared the dependency although none of its sources import the package.