Skip to content

Removed deprecated testing dependency - #7146

Merged
cdavalos7 merged 1 commit into
tensorflow:masterfrom
cdavalos7:feature/upgrade20-21-2
Aug 7, 2026
Merged

Removed deprecated testing dependency#7146
cdavalos7 merged 1 commit into
tensorflow:masterfrom
cdavalos7:feature/upgrade20-21-2

Conversation

@cdavalos7

Copy link
Copy Markdown
Contributor

Motivation for features / changes

@angular/platform-browser-dynamic/testing was deprecated in Angular 21. The
OSS build still accepts it, but the internal build no longer does, so it has to
go.

The internal build also reported a strictDeps error on initialize_testbed.ts:

`error TS2307: [strictDeps] transitive dependency on .../core/index.d.ts
not allowed. Please add the BUILD target to your rule's deps.`

Technical description of changes

  1. testing/initialize_testbed.ts: removed the 2 deprecated symbols for their @angular/platform-browser/testing equivalents, dropped dynamic from platformBrowserDynamicTesting and BrowserDynamicTestingModule.
  2. angular/BUILD: rename expect_angular_platform_browser_dynamic_testing expect_angular_platform_browser_testing, now pointing at @npm//@angular/platform-browser. Its four consumer BUILD files were updated to match.
  3. testing/BUILD: add @npm//@angular/core to initialize_testbed, which is the strictDeps fix.

Some references were removed rather than renamed, because they were not used:

  1. settings/_views/settings_test.ts andapp_routing/views/router_outlet_test.ts imported BrowserDynamicTestingModule without ever using it, so the import lines were removed.
  2. integration_test_module in testing/BUILD declared the dependency although none of its sources import the package.

@cdavalos7
cdavalos7 marked this pull request as ready for review August 7, 2026 00:25
@cdavalos7
cdavalos7 merged commit 1f190fd into tensorflow:master Aug 7, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants