Vendor Vale's new Std package (groundwork, no rule changes) - #5291
Merged
Conversation
Vale 3.20 introduced Std, a shared rule library meant to de-duplicate rules Google/Microsoft both reimplement (Oxford comma, passive voice, sentence length). Vendor it via `vale sync` and bump the documented Vale version so it's available locally, but leave it out of BasedOnStyles for now so no lint behavior changes. Adopting Std to replace the overlapping Google/Microsoft rules is a deliberate follow-up.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
Duncanma
enabled auto-merge (squash)
September 9, 2026 22:42
brianmacdonald-temporal
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vale-actionalready resolves to Vale 3.20.0 via itslatestdefault, so it already meets Std's minimum version.vale/styles/Stdviavale syncand adds it to.vale.ini'sPackagesline, but not toBasedOnStyles— so the rules are on disk but inert. This is groundwork only; no lint behavior changes.AGENTS.md.Test plan
vale --config .vale-ci.ini docs/) produces byte-identical output before/after (confirmed via JSON diff).yarn lint).mdoutput byte-identical before/after;.mdxoutput isolated to the config change alone (same Vale binary, with/withoutStdinPackages) showed 2 lines of difference out of 157k+ findings, traced to pre-existing non-determinism in the repo's double-glob lint script (unrelated to this change —Stdisn't referenced inBasedOnStylesanywhere).vale/styles/Google,Microsoft,alexconfirmed untouched —vale syncincidentally refreshes those too, so that was reverted to keep this change scoped to only the newStdpackage.vale-ci.yml) stays green.