Curate Vale to Std + Temporal rules only (drop Google/Microsoft/alex) - #5299
Merged
Conversation
The full .vale.ini ran ~77 rules from Google/Microsoft/alex, none of them individually chosen to reflect Temporal's writing style -- just whatever came bundled when those packages were first vendored in 2023. .vale-ci.ini, the config that actually gates PRs, only ever enabled 3 of them. Replace the full set with Std (Vale's shared prose-rule library, already vendored as inert groundwork) plus Temporal's own 8 custom rules, and nothing else. Also swaps .vale-ci.ini's Google.Latin for its Std equivalent, and deletes the now fully-unreferenced vendored Google/Microsoft/alex packages. alex was the only package covering inclusive-language and profanity checks; Std has no equivalent. That coverage is dropped without replacement, a deliberate tradeoff rather than an oversight (see the comment in .vale.ini).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview linksThis PR does not change any pages in /docs. If you make updates, links to the modified pages will appear here. |
prasek
pushed a commit
that referenced
this pull request
Sep 11, 2026
…5299) The full .vale.ini ran ~77 rules from Google/Microsoft/alex, none of them individually chosen to reflect Temporal's writing style -- just whatever came bundled when those packages were first vendored in 2023. .vale-ci.ini, the config that actually gates PRs, only ever enabled 3 of them. Replace the full set with Std (Vale's shared prose-rule library, already vendored as inert groundwork) plus Temporal's own 8 custom rules, and nothing else. Also swaps .vale-ci.ini's Google.Latin for its Std equivalent, and deletes the now fully-unreferenced vendored Google/Microsoft/alex packages. alex was the only package covering inclusive-language and profanity checks; Std has no equivalent. That coverage is dropped without replacement, a deliberate tradeoff rather than an oversight (see the comment in .vale.ini).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vale.ini(the full/advisory config) ran ~77 rules fromGoogle, Microsoft, alex, Temporal— none of them individually chosen to reflect Temporal's writing style, just whatever came bundled when those packages were first vendored in 2023..vale-ci.ini(what actually gates PRs) only ever enabled 3 of them (Temporal.Headings,Temporal.RelativeLinks,Google.Latin).Std(Vale's shared prose-rule library, vendored in Vendor Vale's new Std package (groundwork, no rule changes) #5291) plus Temporal's own 8 custom rules, and nothing else.BasedOnStylesis nowVale, Std, Temporal.Std.Readability.SentenceLength[max] = 30to match the oldMicrosoft.SentenceLengththreshold exactly, rather than adopting Std's stricter 25-word default..vale-ci.ini'sGoogle.Latinfor its direct Std equivalent (Std.Abbreviations.Latin), removing the last Google/Microsoft/alex reference from the CI gate.vale/styles/Google,vale/styles/Microsoft,vale/styles/alexpackages (74 files).readme/STYLE.md's opening paragraph — the philosophical lineage (modeled on Google's style guide) stays, but it no longer implies Vale enforces the Google/Microsoft packages directly.Known, deliberate tradeoff: alex was the only package checking inclusive language and profanity (ableist terms, race/LGBTQ terminology, profanity blocklists, condescension). Std has no equivalent (only two narrow rules for gendered pronouns/terms). This coverage is dropped without replacement — documented in a
.vale.inicomment so it reads as a decision, not an oversight.Verification
vale --config .vale-ci.ini docs/):Std.Abbreviations.Latinreproduces everyGoogle.Latinfinding (91 "e.g.", 3 "i.e." — identical) plus 38 new legitimate ones ("etc.", "vs.", whichGoogle.Latindidn't cover). 430 → 468 total findings.yarn lint's two commands), before/after by rule:Std.Grammar.PassiveVoice(22,382, wasGoogle.Passive),Std.Readability.SentenceLength(4,308, wasMicrosoft.SentenceLength— confirms the threshold tuning worked),Std.Usage.FirstPersonPlural(1,947, wasGoogle.We),Std.Usage.FirstPersonSingular(1,071, wasMicrosoft.FirstPerson).Std.Abbreviations.Acronyms(8,100) replaces what were two near-duplicate rules firing separately (Google.Acronyms8,099 +Microsoft.Acronyms8,099) — real de-duplication, not a loss of coverage.Std.Punctuation.OxfordCommafires more (767 vs. 295 combined) — spot-checked, catching real missed-comma cases the old simpler rule didn't.Std.Punctuation.Spacingfires less (689 vs. 1,526) — narrower detection than the old rule.Google.Parens"use parentheses judiciously" alone was 10,851 hits;Google.Headingswas 8,333, mostly redundant with/false-positiving againstTemporal.Headings's curated exception list).alex.*findings (Ablist, Condescending, Race, LGBTQ, ProfanityMaybe/Likely, Suicide) are gone with no replacement — the known tradeoff above.vale/test/*.mdfixtures re-run:bad.md/good.mdstill exerciseTemporal.terms/badwords/complexwordsand Vale's core spelling check correctly;headings-*.mdandrelative-links-*.md(pure Temporal-rule fixtures, untouched by this change) behave identically tomain.git diff --stat: 3 files modified (.vale.ini,.vale-ci.ini,readme/STYLE.md), 74 files deleted, nothing else touched.