Skip to content

Drop zero cadence samples from max_cadence, matching avg_cadence #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tabishm52 merged 1 commit into from
Sep 6, 2026
Merged

Drop zero cadence samples from max_cadence, matching avg_cadence #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/activity_parser/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def fill_activity(activity: Activity, records: pd.DataFrame, laps: pd.DataFrame)
"avg_power": _aggregate(records, "power", "mean"),
"max_power": _aggregate(records, "power", "max"),
"avg_cadence": _aggregate(records, "cadence", "mean", skip_zeros=True),
"max_cadence": _aggregate(records, "cadence", "max"),
"max_cadence": _aggregate(records, "cadence", "max", skip_zeros=True),
}

to_fill = {
Expand Down
9 changes: 9 additions & 0 deletions tests/test_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ def test_avg_power_keeps_zero_samples_avg_cadence_drops_them():
assert activity.avg_cadence == 82.0


def test_all_zero_power_column_reports_zero_all_zero_cadence_column_reports_none():
records = pd.DataFrame({"power": [0.0, 0.0], "cadence": [0.0, 0.0]})
result = fill_activity(Activity(), records, pd.DataFrame())
assert result.avg_power == 0.0
assert result.max_power == 0.0
assert result.avg_cadence is None
assert result.max_cadence is None


def test_fill_activity_ignores_lap_level_sensor_summaries():
# A lap sensor summary can silently be 0 when unpaired; only records are trusted.
laps = pd.DataFrame({"max_heart_rate": [150.0, 160.0], "max_speed": [30.0, 25.0]})
Expand Down