Drop zero cadence samples from max_cadence, matching avg_cadence - #46
Merged
Merged
Conversation
avg_cadence already excludes zero samples for consistency with FIT's own convention, but max_cadence didn't, so an all-zero cadence column reported avg_cadence None and max_cadence 0.0 for the same samples. Apply the same exclusion to max_cadence so the two agree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avg_cadencealready excludes zero samples;max_cadencedidn't, so an all-zero column reportedavg_cadenceNonebutmax_cadence0.0for the same data.max_cadenceso the two agree.Test plan
Nonefor both, an all-zero power column keeps0.0for both.