-
Notifications
You must be signed in to change notification settings - Fork 26
Fix the binary being broken with Symfony Console 8 #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javiereguiluz
merged 1 commit into
symfony-tools:main
from
Amoifr:fix-console-add-command
Jul 29, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Docs Builder package. | ||
| * (c) Ryan Weaver <ryan@symfonycasts.com> | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace SymfonyDocsBuilder\Tests; | ||
|
|
||
| use PHPUnit\Framework\TestCase; | ||
| use Symfony\Component\Process\Process; | ||
|
|
||
| /** | ||
| * The rest of the test suite drives the command through CommandTester, so it | ||
| * never runs the binary itself. This makes sure the binary at least boots. | ||
| */ | ||
| class ApplicationTest extends TestCase | ||
| { | ||
| public function testTheBinaryRegistersTheBuildDocsCommand() | ||
| { | ||
| $process = new Process([\PHP_BINARY, __DIR__.'/../bin/docs-builder', 'list', '--no-ansi']); | ||
| $process->run(); | ||
|
|
||
| $this->assertSame( | ||
| 0, | ||
| $process->getExitCode(), | ||
| sprintf("The binary failed to run:\n%s", $process->getErrorOutput()) | ||
| ); | ||
| $this->assertStringContainsString('build:docs', $process->getOutput()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could probably drop support for old versions of symfony components there. This tool is used by the Symfony website (which is on modern Symfony versions) and by the CI of the symfony-docs repo.
Alternatively, if we never use its CLI, we might drop it entirely