Fix the binary being broken with Symfony Console 8 - #209
Open
Amoifr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #208:
bin/docs-buildercurrently dies on startup with Symfony Console 8.Application::add()was deprecated in Symfony 7.4 in favor ofaddCommand(), and removed in 8.0. Since composer.json allowssymfony/console: ^5.2 || ^6.0 || ^7.0 || ^8.0, the call is guarded rather than swapped outright —addCommand()only exists from 7.4 on:Why CI never caught this: the whole suite drives the command through
CommandTester, so the binary — and thereforeApplication— is never executed. The new test runsbin/docs-builder listas a subprocess and asserts it boots and registersbuild:docs. It fails without the fix (exit code 255, the fatal above) and passes with it.Verified by hand too: a full
bin/docs-builder build:docs <source> <output> --symfony-version=4.0now completes and writes the HTML files.Full suite green: 69 tests, 156 assertions.