chore: one matrix job per kind of test in CI - #16844
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/00a543fbd94a87be6d3ad8f7f2e1f1899f9ab5daOpen in |
|
Nic-Polumeyv
changed the title
same test plan, one set of steps; the unit legs get their own job
…s-platform leg they were the only unit run on windows, which kept them on the macOS and firefox critical paths too
…legs, 3 on macOS the 2-way js cut lands both client.test.js files in one shard (274s vs 192s); 4 workers measured ~9% faster than 2 on the same slice
4 workers oversubscribes the windows runner (worker teardown timeouts, no speedup); the third shard bought critical path with runner-minutes, and kit runs share a contended pool 88% of the time, so runner-minutes are what wall-clock follows
test:others generates kit's types itself so every row runs the same steps
Nic-Polumeyv
changed the title
Nic-Polumeyv
marked this pull request as ready for review
August 19, 2026 04:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #16842.
The e2e legs were six copies of the same job with different scripts wired in. They're now one
e2ematrix (rows are{ script, project, shard, os, browser, workers }) and onetestmatrix for unit tests, which also gives kit's unit tests a Windows leg outsidetest:cross-platform:dev.basicsruns its js project in two shards and its no-js project alone (KIT_E2E_SHARD,KIT_E2E_PROJECTintest/utils.js); Playwright shards by contiguous test count, so a shard straddling the two projects was the 7m/1m40 split.Longest job 14m → 6.5m, coverage and runner-minutes unchanged. 88% of kit runs share the org's 60-slot pool with another kit run, so cutting runner-minutes means dropping cells, which is a separate decision.