Skip to content

chore: declare e2e coverage variants in one place - #16845

Open
Nic-Polumeyv wants to merge 8 commits into
faster-testsfrom
e2e-variants
Open

chore: declare e2e coverage variants in one place#16845
Nic-Polumeyv wants to merge 8 commits into
faster-testsfrom
e2e-variants

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Adding an e2e coverage variant (a server config flag such as SVELTE_ASYNC or ROUTER_RESOLUTION) currently means a script per variant per mode in the test app's package.json, another in packages/kit/package.json, another at the root, a hand-written webServer.env in the app's playwright.config.js, and tests reading the raw env var; CI rows then name the root script. #14644 copied #13379's block for this and asked whether that was right; nothing decided it. Playwright can't express these as projects because webServer is config-level and every entry boots regardless of --project.

Each app now declares its variants once in configure() (packages/kit/test/utils.js): a name mapping to the server env it needs. KIT_E2E_VARIANT selects one per run, which sets webServer.env, suffixes the project names and is exported as variant for tests. CI rows carry variant as data next to project/shard and name the apps directly, so the root and kit script layers that only existed to fan variants out are gone. Coverage is unchanged: same tests, same 26 jobs, same triggers (--list per cell before/after is identical up to the project-name suffix). This is the plumbing for trimming the matrix afterwards: which cells run, and with which variant, becomes a row edit rather than a script added at three layers.

options-2's REGISTER_SERVICE_WORKER / NODE_ENV=custom DYNAMIC_PUBLIC_ENV runs are now the service-worker and dynamic-env variants.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 19, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 1aa4828:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1aa4828ab6efd6f5752dc8688a0d391899ae7e85

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16845

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1aa4828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Nic-Polumeyv
Nic-Polumeyv force-pushed the e2e-variants branch 2 times, most recently from 1d54a06 to d944f0f Compare August 19, 2026 05:26
@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review August 19, 2026 15:24
Base automatically changed from shard-basics to faster-tests August 19, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant