chore: declare e2e coverage variants in one place - #16845
Open
Nic-Polumeyv wants to merge 8 commits into
Open
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1aa4828ab6efd6f5752dc8688a0d391899ae7e85Open in |
|
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
2 times, most recently
from
August 19, 2026 05:26
1d54a06 to
d944f0f
Compare
Nic-Polumeyv
marked this pull request as ready for review
August 19, 2026 15:24
…nd drop the per-variant scripts
Nic-Polumeyv
force-pushed
the
e2e-variants
branch
from
August 19, 2026 16:38
5934db2 to
1aa4828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an e2e coverage variant (a server config flag such as
SVELTE_ASYNCorROUTER_RESOLUTION) currently means a script per variant per mode in the test app'spackage.json, another inpackages/kit/package.json, another at the root, a hand-writtenwebServer.envin the app'splaywright.config.js, and tests reading the raw env var; CI rows then name the root script. #14644 copied #13379's block for this and asked whether that was right; nothing decided it. Playwright can't express these as projects becausewebServeris config-level and every entry boots regardless of--project.Each app now declares its variants once in
configure()(packages/kit/test/utils.js): a name mapping to the server env it needs.KIT_E2E_VARIANTselects one per run, which setswebServer.env, suffixes the project names and is exported asvariantfor tests. CI rows carryvariantas data next toproject/shardand name the apps directly, so the root and kit script layers that only existed to fan variants out are gone. Coverage is unchanged: same tests, same 26 jobs, same triggers (--listper cell before/after is identical up to the project-name suffix). This is the plumbing for trimming the matrix afterwards: which cells run, and with which variant, becomes a row edit rather than a script added at three layers.options-2's
REGISTER_SERVICE_WORKER/NODE_ENV=custom DYNAMIC_PUBLIC_ENVruns are now theservice-workeranddynamic-envvariants.