Skip to content

Print nothing from PreToolUse for tools other than recall #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntindle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Print nothing from PreToolUse for tools other than recall #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions hooks/recall-approve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,11 @@ async function main() {
});
return;
}

writeOutput({ continue: true, suppressOutput: true });
// Any other tool: no output, so Muse applies its normal approval. Muse 1.4.4 rejects
// `continue` in PreToolUse output and logs the hook as failed on every tool call.
} catch (err) {
debugLog(settings, 'Recall approve error', { error: err.message });
writeOutput({ continue: true, suppressOutput: true });
}
}

main().catch(() => {
writeOutput({ continue: true, suppressOutput: true });
});
main().catch(() => {});
3 changes: 1 addition & 2 deletions test/unit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ describe('hooks', () => {
input: JSON.stringify({ tool_name: 'mcp__supermemory__add_memory' }),
});
assert.equal(result.status, 0, result.stderr);
const out = JSON.parse(result.stdout.trim().split('\n').at(-1));
assert.equal(out.continue, true);
assert.equal(result.stdout.trim(), '');
});
});

Expand Down