Skip to content

Print nothing from PreToolUse for tools other than recall - #3

Open
ntindle wants to merge 1 commit into
supermemoryai:mainfrom
ntindle:fix/pretooluse-no-continue
Open

ntindle wants to merge 1 commit into
supermemoryai:mainfrom
ntindle:fix/pretooluse-no-continue

Conversation

@ntindle

@ntindle ntindle commented Oct 11, 2026 •

Copy link
Copy Markdown

Problem

Muse Code 1.4.4 checks PreToolUse hook output and rejects continue there. hooks/recall-approve.js prints {"continue": true, "suppressOutput": true} for every tool that isn't one of Supermemory's read-only recall tools, so since 1.4.4 every tool call records this hook as failed:

unsupported `continue` in output of PreToolUse hook output

The tool call itself still runs, but the session log has a failed hook run per tool call, and hosts that show hook runs (T3 Code, for one) list each as a failed item. Session start, prompt recall and capture are unaffected.

Change

For tools other than the recall tools, the hook now prints nothing and exits 0. That is what the pass-through meant: no decision, so Muse applies its normal approval. The allow path for search_memory and the other read-only tools is unchanged (hookSpecificOutput with permissionDecision: "allow" and a reason), and Muse 1.4.4 accepts it. The error paths print nothing too.

Tests

node --test test/unit.mjs: 7 pass (Node 24, Windows). The existing "does not auto-allow writes" case now expects empty output instead of continue: true; it fails on main. muse plugins validate . passes on Muse 1.4.4.

I run the same hook change on top of #2's branch (which doesn't touch this file) on four machines (Windows, macOS, two Linux). In real Muse 1.4.4 sessions with tool calls, recall-approve now completes, and session start, recall and capture still complete. Before the change each tool call logged the error above.

This is independent of #2: it changes different code, and the two only meet in test/unit.mjs, in different places (a test merge of both branches is clean).

🤖 Generated with Claude Code

Muse 1.4.4 rejects `continue` in PreToolUse hook output ("unsupported
`continue` in output of PreToolUse hook output") and records the hook as
failed on every tool call; T3 shows each as a failed item. With no output
Muse applies its normal approval, which is what the pass-through meant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant