Repository navigation
fix(release): preserve beta publish terminal - #88
Merged
Merged
Conversation
Bun Shell piped publisher output, so npm rejected EOTP before it could offer browser authorization or an OTP prompt. Spawn the existing Changesets command with inherited stdio and retain nonzero exit handling so the registry-state probe still runs after publish failures. Cover terminal inheritance with a real-PTY regression and document the explicit npm browser override for sandboxed local releases. Keep account 2FA, stable OIDC publishing, and beta confirmation guards unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the terminal boundary so npm can offer browser authorization when the registry returns a web challenge, or prompt for an OTP otherwise. Document the explicit
npm_config_browser="$PLANNOTATOR_BROWSER"override for agent-sandbox, including host/forwarded-browser routing. Keep account 2FA, confirmation guards, registry checks, cleanup, and stable OIDC releases unchanged.No changeset: local release tooling, tests, and documentation only; no shipped plugin behavior or package API changes.
Evidence
{"stdin":true,"stdout":false,"stderr":false}using the original Bun Shell invocation.After: the same fixture passes with all three TTY flags true,
--no-git-tagforwarded, and the browser override preserved.bun run lint,bun run typecheck,bun run test(204 passed),bun run verify:pack, andgit diff --checkpass. Both new tests also pass on CI's Bun 1.3.11.Merge Danger
Door: two-way
Revert this commit to restore the previous publisher invocation. This PR does not publish a package or change authentication policy.
Blast Radius: local-release
Only the local beta publisher's terminal handling changes. Interactive authorization still depends on the challenge offered by npm and on an available browser bridge.