Repository navigation
fix(release): wait for npm beta propagation - #89
Merged
Merged
Conversation
npm can accept a beta publish before its dist-tag becomes visible. The 90-second check could report failure and recommend retagging while npm still processed the upload. Use a shared five-minute polling budget for success and error probes, stop on latest drift, and treat stale metadata as unresolved rather than suggesting another publish or dist-tag change. Add virtual-clock regressions and document read-only checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the existing polling helper and release guards. Move failed-publish polling inside the registry-probe error boundary, add virtual-clock regression cases, and document read-only checks for unresolved registry state.
No changeset: local release tooling, tests, and docs only; no shipped plugin or package API changes. Follow-up to #88.
Evidence
After: the production-budget regression tolerates two-minute visibility delay, latest drift stops without sleeping, and permanently stale metadata stops at the deadline.
bun run lint,bun run typecheck,bun run test(207 passed),bun run verify:pack, andgit diff --checkpass. Existing real-PTY browser authorization regression still passes.Merge Danger
Door: two-way
Revert the commit to restore previous polling and messages. This PR does not publish a package.
Blast Radius: local-release
A local beta publish can spend up to five minutes polling for metadata instead of 90 seconds. Registry-read failures remain errors; unresolved metadata no longer recommends a potentially unsafe retry or retag.