Skip to content

chore: fix JavaScript lint errors (issue #16391) #16400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manoj-codes27 wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −4
Open

chore: fix JavaScript lint errors (issue #16391) #16400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db6add
chore: fix JavaScript lint errors (issue #16391)
manoj-codes27 Oct 31, 2026
f4960fa
Merge branch 'develop' into fix/contribution-2
manoj-codes27 Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/scripts/common/lint_javascript_files_error_log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ run_make_lint() {

local eslint_flags=""
if [ "${quiet}" -eq 1 ]; then
eslint_flags="ESLINT_FLAGS='--quiet'"
eslint_flags="STDLIB_ESLINT_FLAGS='--quiet'"
fi

local make_cmd="make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} ${eslint_flags}"
Expand All @@ -92,7 +92,7 @@ run_make_lint() {
if ! eval "${make_cmd}"; then
if [ "${quiet}" -eq 0 ]; then
echo "Initial linting failed. Retrying with --quiet and logging errors..."
eval "make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} ESLINT_FLAGS='--quiet'" >> "${err_file}" 2>&1
eval "make lint-javascript-files FIX=${fix} FAST_FAIL=0 FILES=\"${files_to_lint}\" ${make_args} ${eslint_conf_arg} STDLIB_ESLINT_FLAGS='--quiet'" >> "${err_file}" 2>&1
else
# Already running with --quiet, just log the error
echo "Linting failed for files." >> "${err_file}"
Expand Down
4 changes: 2 additions & 2 deletions tools/make/lib/lint/javascript/eslint.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ eslint_flags := \
--report-unused-disable-directives

# Define user-supplied command-line options:
ESLINT_FLAGS ?=
STDLIB_ESLINT_FLAGS ?=

ifeq ($(AUTOFIX),true)
eslint_flags += --fix
Expand All @@ -50,7 +50,7 @@ endif
endif

# Append user-supplied command-line options:
eslint_flags += $(ESLINT_FLAGS)
eslint_flags += $(STDLIB_ESLINT_FLAGS)

# RULES #

Expand Down
Loading