Skip to content

chore: fix JavaScript lint errors (issue #16391) - #16400

Open
manoj-codes27 wants to merge 2 commits into
stdlib-js:developfrom
manoj-codes27:fix/contribution-2
Open

manoj-codes27 wants to merge 2 commits into
stdlib-js:developfrom
manoj-codes27:fix/contribution-2

Conversation

@manoj-codes27

@manoj-codes27 manoj-codes27 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status:
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: missing_dependencies
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed

Resolves #16391.

Description

Fixes JavaScript linting failures caused by a naming conflict between the stdlib Make variable ESLINT_FLAGS and ESLint's reserved environment variable of the same name.

This pull request:

  • Renames the stdlib Make variable from ESLINT_FLAGS to STDLIB_ESLINT_FLAGS.
  • Updates the JavaScript linting Makefile to use the renamed variable.
  • Updates the GitHub Actions workflow script to pass the renamed variable when retrying JavaScript lint checks.

Related Issues

This pull request has the following related issues:

Reference Packages

This pull request did not follow an existing package. It modifies shared JavaScript linting infrastructure.

What carried over from the reference(s)?

  • Not applicable.

What differed, or what did you have to work out yourself?

  • Identified the conflict between the stdlib Make variable and ESLint's reserved ESLINT_FLAGS environment variable.
  • Traced the failure through the Makefile and ESLint implementation.

Questions

No.

Other

  • Reproduced the original ESLint failure locally.
  • Tested all 13 benchmark files reported in the CI failure.
  • Verified the updated lint command and shell script syntax.
  • git diff --check passed.
  • The ShellCheck pre-commit check reported a missing dependency because ShellCheck was not installed at commit time.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I used AI assistance for researching the ESLint environment-variable conflict, understanding the root cause, and guiding the debugging process. I independently applied the code changes and performed local testing and validation.


@stdlib-js/reviewers

@manoj-codes27
manoj-codes27 requested a review from a team October 31, 2026 08:15
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Oct 31, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: missing_dependencies
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants