blockifier,starknet_os: expect the blake constants in tests and check consistency#14035
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview Updates Blockifier and Starknet OS Blake tests to assert against these expectations (instead of hard-coded equality) and adds a consistency test ensuring the production constants remain in sync with the expected baselines. Also wires Reviewed by Cursor Bugbot for commit 8b75bd9. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 57722b6. Configure here.
57722b6 to
c2492f9
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 2 discussions.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on AvivYossef-starkware and Yoni-Starkware).
c2492f9 to
4cdda7f
Compare
30206ec to
139758c
Compare
4cdda7f to
917ff62
Compare
139758c to
7307bab
Compare
917ff62 to
bec3ce4
Compare
7307bab to
9bb0f78
Compare
9bb0f78 to
dc54cc6
Compare
bec3ce4 to
8b75bd9
Compare


No description provided.