Skip to content

starknet_os: move blake constants to struct scope#14031

Open
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_extract_cairo_blake_run_to_functionfrom
05-15-starknet_os_move_blake_constants_to_struct_scope
Open

starknet_os: move blake constants to struct scope#14031
dorimedini-starkware wants to merge 1 commit into
05-15-starknet_os_extract_cairo_blake_run_to_functionfrom
05-15-starknet_os_move_blake_constants_to_struct_scope

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 15, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 15, 2026

PR Summary

Low Risk
Low risk refactor that only changes how Blake hash estimation constants are defined/visible; behavior should remain the same, but any downstream code relying on the previous private visibility could be affected.

Overview
Moves the empirical Blake hash estimation constants used by CasmV2HashResourceEstimate from function-local consts to public associated constants on the struct, and updates the estimator to reference them via Self::….

This makes the constants reusable outside the function while keeping the step-calculation logic unchanged (including base costs for full vs partial 16-u32 messages and per-felt step multipliers).

Reviewed by Cursor Bugbot for commit b1aa788. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants