Conversation
Keep existing Balar runtime behavior while exposing packet definitions to standalone C/C++ and firmware clients. Include the new header in builds and staged CUDA-runtime tests; add focused C/C++ compilation and layout checks.
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Balar's packet definitions currently require CUDA headers and C++ namespaces, preventing standalone C and firmware peers from sharing them. Extract the definitions into balar_packet_wire.h, preserve existing CUDA-enabled C++ packet declarations, and keep balar_packet.h as the existing runtime-facing wrapper. Include the new header in the build and staged runtime tests.
This layer contains only the shared header, compatibility handling, build/staging changes, and focused C/C++ compilation and layout tests. Existing runtime sources are unchanged.
Validation:
First layer of the
balar-*replacement stack for #2690, targeting current upstreamdevel.Stack (review order):