Repository navigation
fix(ci): make sync-upstream.yml valid YAML again - #9
Merged
Merged
Conversation
The notice step merged in #8 wrote a plain scalar with ": " inside it, which YAML reads as a second mapping key. GitHub refused the file, so the push to main produced a failed run with no jobs, and the hourly sync and the ftw-release dispatch from srcfl/ftw both stopped. Use a block scalar for the echo. Add a test that parses every workflow file, because the existing tests read them as text and could not catch this. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8. Its notice step wrote a plain scalar with
:inside it, which YAML reads as a second mapping key. GitHub refused the file: the push tomainproduced a failed run with no jobs ("Invalid workflow file: .github/workflows/sync-upstream.yml#L42"). Until this lands the hourly sync does not run and theftw-releasedispatch from srcfl/ftw has nothing to reach.Publish beta for v3.4.2-beta.4 was not affected; it ran through
auto-publish.ymland succeeded.Change
sync-upstream.yml: the echo moves to a block scalar. No other change.tests/test_automation_workflows.py:WorkflowSyntaxTestsparses every file under.github/workflowswith PyYAML. The existing workflow tests read the files as text, so they could not catch this.Validation
python -m unittest discover -s tests -p 'test_*.py': all pass on this branch.sync-upstream.ymlat line 42, column 56.python -m compileall -q scripts tests/fixtures: clean.🤖 Generated with Claude Code