Repository navigation
fix(ci): follow the Check run the sync dispatched, not the PR's - #12
Merged
Merged
Conversation
GitHub opens a pull_request run of Check for the bot's pin PR and holds it for maintainer approval. The sync picked the newest run at the head commit, which was that one, and "Merge when checks pass" failed on action_required although the dispatched run had passed. Filter the run lookup on the workflow_dispatch event. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8, #9 and #10. Sync run 35311179451 pinned v3.7.1-beta.1, opened #11, dispatched Check on the branch and saw it pass, then failed "Merge when checks pass" with:
Two Check runs existed at the same commit: the
workflow_dispatchrun the sync started (green), and apull_requestrun GitHub opened for the bot's PR and holds "awaiting approval from a maintainer". The lookup took the newest run at the head commit, which was the held one.Change
sync-upstream.yml: the run lookup passes--event workflow_dispatch, so the sync follows the run it dispatched.tests/test_automation_workflows.py: asserts the filter is present.#11 was merged by hand with the green dispatched run as evidence. Nothing here changes what the sync pins or publishes.
Validation
python -m unittest discover -s tests -p 'test_*.py': 161 tests pass.🤖 Generated with Claude Code