feat(server): declare public image assets cross-origin - #5916
Merged
Conversation
Contributor
|
This comment has been minimized.
This comment has been minimized.
walker-tx
force-pushed
the
walker/ais-552-corp-resource-policy
branch
from
August 31, 2026 23:52
f380784 to
160e96f
Compare
walker-tx
force-pushed
the
walker/ais-552-corp-resource-policy
branch
from
September 1, 2026 00:02
160e96f to
891c823
Compare
disintegrator
approved these changes
Sep 1, 2026
walker-tx
force-pushed
the
walker/ais-552-corp-resource-policy
branch
from
September 1, 2026 15:00
891c823 to
2ce4b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIS-552
Summary
Cross-Origin-Resource-Policyas a required successfulassets.serveImageresponse header.cross-originvalue while preservingAccess-Control-Allow-Origin: *.Motivation
Uploaded branding is intentionally loaded as a plain image by install and OAuth consent pages, including pages on custom domains. The endpoint needs an explicit policy that permits that supported cross-site use.
Stack
gram-infracompanion PR adds the policy to CDN assets.Rollout gates
cross-origin.Related PR