Skip to content

feat(server): declare public image assets cross-origin - #5916

Merged
walker-tx merged 3 commits into
mainfrom
walker/ais-552-corp-resource-policy
Sep 1, 2026
Merged

feat(server): declare public image assets cross-origin#5916
walker-tx merged 3 commits into
mainfrom
walker/ais-552-corp-resource-policy

Conversation

@walker-tx

@walker-tx walker-tx commented Aug 31, 2026

Copy link
Copy Markdown
Member

AIS-552

Summary

  • Declare Cross-Origin-Resource-Policy as a required successful assets.serveImage response header.
  • Return the fixed cross-origin value while preserving Access-Control-Allow-Origin: *.
  • Regenerate the Goa service, HTTP transport, and OpenAPI artifacts and cover the policy in the existing service test.

Motivation

Uploaded branding is intentionally loaded as a plain image by install and OAuth consent pages, including pages on custom domains. The endpoint needs an explicit policy that permits that supported cross-site use.

Stack

Rollout gates

  • In dev, confirm an uploaded logo keeps its absolute platform URL, renders on a custom-domain install page, and returns exact cross-origin.
  • Confirm OAuth consent branding and a Gram Elements chat turn have no new CORS or CORP regressions.
  • Repeat the dashboard-root and sticker checks after production promotion.

Related PR

@walker-tx
walker-tx requested a review from a team as a code owner August 31, 2026 21:05
@walker-tx walker-tx added the enhancement New feature or request label Aug 31, 2026
@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

AIS-552

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2ce4b64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@blacksmith-sh

This comment has been minimized.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Re-trigger cubic

@walker-tx
walker-tx force-pushed the walker/ais-552-corp-resource-policy branch from f380784 to 160e96f Compare August 31, 2026 23:52
@walker-tx
walker-tx requested a review from a team as a code owner September 1, 2026 00:02
@walker-tx
walker-tx force-pushed the walker/ais-552-corp-resource-policy branch from 160e96f to 891c823 Compare September 1, 2026 00:02
@walker-tx
walker-tx force-pushed the walker/ais-552-corp-resource-policy branch from 891c823 to 2ce4b64 Compare September 1, 2026 15:00
@walker-tx
walker-tx added this pull request to the merge queue Sep 1, 2026
Base automatically changed from walker/ais-552-external-corp to main September 1, 2026 15:14
Merged via the queue into main with commit b096302 Sep 1, 2026
44 checks passed
@walker-tx
walker-tx deleted the walker/ais-552-corp-resource-policy branch September 1, 2026 15:15
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants