feat(dashboard): declare external assets cross-origin - #5915
Merged
Conversation
Contributor
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
walker-tx
force-pushed
the
walker/ais-552-external-corp
branch
from
September 1, 2026 00:02
23ace36 to
28dfb67
Compare
disintegrator
approved these changes
Sep 1, 2026
walker-tx
force-pushed
the
walker/ais-552-external-corp
branch
from
September 1, 2026 15:00
28dfb67 to
ce9b23e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIS-552
Summary
/external/*dashboard resource withCross-Origin-Resource-Policy: cross-originand the existing wildcard CORS policy.same-originvalue on dashboard HTML and SPA fallback responses.Motivation
The public sticker logo is embedded by install pages on custom domains. Giving the
/externalresource family an explicit permissive policy preserves that supported cross-site load without weakening the dashboard HTML remediation.Stack
This is the base of a two-PR Gram stack. The follow-up adds the same explicit policy to uploaded image responses.
Rollout gates
same-originand the sticker response iscross-origin.Related PRs