Skip to content

feat(dashboard): declare external assets cross-origin - #5915

Merged
walker-tx merged 1 commit into
mainfrom
walker/ais-552-external-corp
Sep 1, 2026
Merged

feat(dashboard): declare external assets cross-origin#5915
walker-tx merged 1 commit into
mainfrom
walker/ais-552-external-corp

Conversation

@walker-tx

@walker-tx walker-tx commented Aug 31, 2026

Copy link
Copy Markdown
Member

AIS-552

Summary

  • Serve every /external/* dashboard resource with Cross-Origin-Resource-Policy: cross-origin and the existing wildcard CORS policy.
  • Preserve the pentest-approved same-origin value on dashboard HTML and SPA fallback responses.
  • Include the approved Gram and CDN implementation plans.

Motivation

The public sticker logo is embedded by install pages on custom domains. Giving the /external resource family an explicit permissive policy preserves that supported cross-site load without weakening the dashboard HTML remediation.

Stack

This is the base of a two-PR Gram stack. The follow-up adds the same explicit policy to uploaded image responses.

Rollout gates

  • After dev deployment, confirm dashboard HTML remains exactly same-origin and the sticker response is cross-origin.
  • Confirm default sticker branding renders on a custom-domain install page, then repeat the header checks after production promotion.

Related PRs

@walker-tx
walker-tx requested review from a team as code owners August 31, 2026 21:05
@walker-tx walker-tx added the enhancement New feature or request label Aug 31, 2026
@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

AIS-552

@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ce9b23e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread docs/superpowers/plans/2026-08-31-ais-552-cdn-asset-corp.md Outdated
Comment thread docs/superpowers/plans/2026-08-31-ais-552-cdn-asset-corp.md Outdated
Comment thread docs/superpowers/plans/2026-08-31-ais-552-gram-public-resource-corp.md Outdated
@walker-tx
walker-tx force-pushed the walker/ais-552-external-corp branch from 23ace36 to 28dfb67 Compare September 1, 2026 00:02
@walker-tx
walker-tx force-pushed the walker/ais-552-external-corp branch from 28dfb67 to ce9b23e Compare September 1, 2026 15:00
@walker-tx
walker-tx added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 30992e4 Sep 1, 2026
42 checks passed
@walker-tx
walker-tx deleted the walker/ais-552-external-corp branch September 1, 2026 15:14
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants