Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions packages/eslint-plugin-solid/docs/reactivity.md
Original file line number Diff line number Diff line change
Expand Up @@ -1603,6 +1603,46 @@ const scaled = createMemo(() => {
return items.map(scale);
});

import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal(new Map());
function handleSave() {
const snapshot = items();
function look(id) {
return snapshot.get(id) || id;
}
console.log(look("a"));
}
return <button onClick={handleSave}>x</button>;
}

import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal(new Map());
function handleSave() {
const snapshot = items();
function look(id) {
return snapshot.get(id) || id;
}
console.log(["a"].map(look));
}
return <button onClick={handleSave}>x</button>;
}

import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal([]);
function handleSave() {
const snapshot = items();
function look(id) {
console.log(snapshot);
return id;
}
look("a");
}
return <button onClick={handleSave}>x</button>;
}

```
<!-- end-doc-gen -->

Expand Down
4 changes: 3 additions & 1 deletion packages/eslint-plugin-solid/src/rules/reactivity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,9 @@ export default createRule<Options, MessageIds>({
? closure.parent
: null;
if (!declaration) return false;
const variables = sourceCode.scopeManager?.getDeclaredVariables(declaration) ?? [];
const variables = (sourceCode.scopeManager?.getDeclaredVariables(declaration) ?? []).filter(
(variable) => variable.defs.some((def) => def.type !== "Parameter")
);
return variables.some((variable) =>
variable.references.some(
(reference) => !reference.init && isReferenceReturned(reference.identifier, boundary)
Expand Down
37 changes: 37 additions & 0 deletions packages/eslint-plugin-solid/test/rules/reactivity.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,43 @@ export const cases = run("reactivity", rule, {
const scale = (v) => v * total;
return items.map(scale);
});`,
`import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal(new Map());
function handleSave() {
const snapshot = items();
function look(id) {
return snapshot.get(id) || id;
}
console.log(look("a"));
}
return <button onClick={handleSave}>x</button>;
}`,
`import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal(new Map());
function handleSave() {
const snapshot = items();
function look(id) {
return snapshot.get(id) || id;
}
console.log(["a"].map(look));
}
return <button onClick={handleSave}>x</button>;
}`,
`import { createSignal } from "solid-js";
function Comp() {
const [items] = createSignal([]);
function handleSave() {
const snapshot = items();
function look(id) {
console.log(snapshot);
return id;
}
look("a");
}
return <button onClick={handleSave}>x</button>;
}`,
],
invalid: [
// Untracked signals
Expand Down
Loading