Repository navigation
fix(reactivity): ignore helper parameters in staleCapture - #269
Open
anubhavlal07 wants to merge 1 commit into
Open
anubhavlal07 wants to merge 1 commit into
anubhavlal07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solid/reactivityreportsstaleCaptureon a snapshot taken inside an event handler when a helper function declared inside that handler reads it, even though the helper is only called synchronously and never returned.This is a regression from #260.
isDeclaredClosureReturnedcallsscopeManager.getDeclaredVariables(declaration). For aFunctionDeclaration, that returns the function-name variable plus one variable per parameter, so references to the helper's own parameters were also checked for escaping. In the repro, theidinreturn snapshot.get(id) ?? id;sits insidelook's ownreturn.isReferenceReturnedhits thatReturnStatementbefore it reacheslook's function boundary, so the rule concludes thatlookescapeshandleSave.Fix
isDeclaredClosureReturnednow skips variables whose only definition is aParameter. Only the variable that names the closure is checked. TheVariableDeclaratorbranch already returned only the declared name, so its behavior is unchanged.Tests
Added three valid cases to
test/rules/reactivity.test.ts:look("a")called synchronously["a"].map(look)variantreturn id;), which tests the parameter trigger directlyAll three fail without the fix, on every parser. The existing #258 invalid cases (
return <button onClick={onClick}>,return read) still report.PARSER=all vitest --runpasses, and so dopnpm build,pnpm lintandpnpm tsc.docs/reactivity.mdwas regenerated from the new cases.Fixes #268