Skip to content

Fix flaky check_pipe native spec on Windows #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Watson1978 merged 1 commit into from
Oct 21, 2026
+14 −3
Merged

Fix flaky check_pipe native spec on Windows #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions spec/fixtures/windows_stat_native.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ check_pipe (VALUE self, VALUE path)
ev_stat watcher;
ev_timer timeout;
ev_async async;
ev_tstamp deadline;
WSADATA data;
FILE *file;
const char *error = 0;
Expand Down Expand Up @@ -183,10 +184,20 @@ check_pipe (VALUE self, VALUE path)

fail_socket = 0;
socket_calls = 0;
ev_run (loop, EVRUN_ONCE); /* The next polling tick retries notification setup. */
deadline = ev_time () + 5;
while (!loop->win32_fs && ev_time () < deadline)
{
ev_run (loop, EVRUN_ONCE); /* The next polling tick retries notification setup. */
}
/* One listener plus one client socket; ev_async_start must reuse this pair. */
if (!loop->win32_fs || !ev_is_active (&loop->pipe_w) || socket_calls != 2)
error = "notification recovery did not reuse the prepared pipe";
if (!loop->win32_fs)
{
error = "polling did not retry notification setup";
}
else if (!ev_is_active (&loop->pipe_w) || socket_calls != 2)
{
error = "notification recovery did not reuse the prepared pipe";
}
cleanup:
ev_stat_stop (loop, &watcher);
ev_loop_destroy (loop);
Expand Down
Loading