Repository navigation
Fix flaky check_pipe native spec on Windows - #126
Merged
Merged
Conversation
The spec ran EVRUN_ONCE once and expected the 0.1 second polling tick to retry the notification setup. On Windows, select can return just before the timer is due, so the retry had not happened yet and the spec reported that the prepared pipe was not reused. Run the loop until the setup is retried, for up to 5 seconds, and report a missing retry separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native spec for pipe failure recovery ran
ev_run (loop, EVRUN_ONCE)once and expected the 0.1 second polling tick to retry the notification setup. On Windows,selectcan return just before the timer is due, so the spec sometimes reported "notification recovery did not reuse the prepared pipe" in CI, as in this job. This runs the loop until the setup is retried, for up to 5 seconds, and reports a missing retry with its own message. WithEVRUN_NOWAITin place ofEVRUN_ONCE, the old spec fails every time and the new one passes.Types of Changes
Contribution
🤖 Generated with Claude Code