Skip to content

refactor: remove unused SortedKeys function #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwbrooks merged 2 commits into from
Oct 19, 2026
Merged

refactor: remove unused SortedKeys function #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb03dd9
refactor: remove unused SortedKeys function
mwbrooks Oct 14, 2026
01ffbcf
Merge branch 'main' into mwbrooks-remove-dead-sorted-keys
mwbrooks Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions internal/manifest/flatten.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package manifest

import (
"encoding/json"
"sort"
"strings"

"github.com/slackapi/slack-cli/internal/slackerror"
Expand Down Expand Up @@ -69,13 +68,3 @@ func escapePathSegment(s string) string {
s = strings.ReplaceAll(s, `.`, `\.`)
return s
}

// SortedKeys returns the keys of a flat map in sorted order for deterministic output.
func SortedKeys(m map[string]any) []string {
keys := make([]string, 0, len(m))
for k := range m {
keys = append(keys, k)
}
sort.Strings(keys)
return keys
}
10 changes: 0 additions & 10 deletions internal/manifest/flatten_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,3 @@ func Test_Flatten_DottedKeyRoundTrip(t *testing.T) {
assert.Equal(t, "Lookup", round.Functions["slack.users.lookup"].Title)
assert.Equal(t, "Lookup a user", round.Functions["slack.users.lookup"].Description)
}

func Test_SortedKeys(t *testing.T) {
m := map[string]any{
"z.field": "val",
"a.field": "val",
"m.field": "val",
}
keys := SortedKeys(m)
assert.Equal(t, []string{"a.field", "m.field", "z.field"}, keys)
}
Loading