Skip to content

refactor: remove unused SortedKeys function - #703

Merged
mwbrooks merged 2 commits into
mainfrom
mwbrooks-remove-dead-sorted-keys
Oct 19, 2026
Merged

mwbrooks merged 2 commits into
mainfrom
mwbrooks-remove-dead-sorted-keys

Conversation

@mwbrooks

Copy link
Copy Markdown
Member

Changelog

N/A - internal cleanup with no user-facing changes.

Summary

This pull request removes the unused SortedKeys function found with the Go deadcode tool.

  • Removes SortedKeys from internal/manifest/flatten.go
  • Removes its unit test from internal/manifest/flatten_test.go

Testing

  1. Run go run golang.org/x/tools/cmd/deadcode@latest ./... | grep SortedKeys and confirm there's no output
  2. Run grep -rn "SortedKeys" --include='*.go' . and confirm there are no references left

Requirements

@mwbrooks
mwbrooks requested a review from a team as a code owner October 14, 2026 16:38
@mwbrooks mwbrooks added this to the Next Release milestone Oct 14, 2026
@mwbrooks mwbrooks added code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment labels Oct 14, 2026
@mwbrooks mwbrooks self-assigned this Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.12%. Comparing base (5bfb60e) to head (01ffbcf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   78.11%   78.12%   +0.01%     
==========================================
  Files         238      238              
  Lines       18122    18117       -5     
==========================================
- Hits        14156    14154       -2     
+ Misses       3966     3963       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej srtaalej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping our code clean!

@mwbrooks

Copy link
Copy Markdown
Member Author

Thanks for the review @srtaalej! 🙇🏻

@mwbrooks
mwbrooks merged commit fbadbd1 into main Oct 19, 2026
13 checks passed
@mwbrooks
mwbrooks deleted the mwbrooks-remove-dead-sorted-keys branch October 19, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants