Skip to content

ice: support adding peer-reflexive remote candidates in STUN lite #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deltapath-eric wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

ice: support adding peer-reflexive remote candidates in STUN lite #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions external/libre/src/ice/stunsrv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ static int handle_stun_full(struct icem *icem,
*/
static int handle_stun_lite(struct icem *icem,
struct icem_comp *comp, const struct sa *src,
bool use_cand)
uint32_t prio, bool use_cand)
{
struct ice_cand *lcand, *rcand;
struct ice_candpair *cp;
Expand All @@ -186,8 +186,11 @@ static int handle_stun_lite(struct icem *icem,

rcand = icem_cand_find(&icem->rcandl, comp->id, src);
if (!rcand) {
DEBUG_WARNING("lite: could not find remote candidate\n");
return 0;
err = icem_rcand_add_prflx(&rcand, icem, comp->id, prio, src);
if (err) {
DEBUG_WARNING("lite: could not add PeerReflexive remote candidate (%m)\n", err);
return err;
}
}

/* find the local host candidate with the same component */
Expand Down Expand Up @@ -302,7 +305,7 @@ int icem_stund_recv(struct icem_comp *comp, const struct sa *src,
use_cand, presz > 0);
}
else {
err = handle_stun_lite(icem, comp, src, use_cand);
err = handle_stun_lite(icem, comp, src, prio_prflx, use_cand);
}

if (err)
Expand Down