ice: support adding peer-reflexive remote candidates in STUN lite#175
Open
deltapath-eric wants to merge 1 commit into
Open
ice: support adding peer-reflexive remote candidates in STUN lite#175deltapath-eric wants to merge 1 commit into
deltapath-eric wants to merge 1 commit into
Conversation
Fixes an issue where STUN lite handling would drop incoming requests if the remote candidate was not already known. Instead of logging a warning and ignoring the packet, the server now attempts to dynamically add the remote candidate as a Peer-Reflexive (prflx) candidate. Changes: - Update `handle_stun_lite` to accept the `prio` (priority) parameter. - Invoke `icem_rcand_add_prflx` when a remote candidate cannot be found. - Pass `prio_prflx` down from the main STUN message handler into `handle_stun_lite`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where STUN lite handling would drop incoming requests if the remote candidate was not already known. Instead of logging a warning and ignoring the packet, the server now attempts to dynamically add the remote candidate as a Peer-Reflexive (prflx) candidate.
Changes:
handle_stun_liteto accept theprio(priority) parameter.icem_rcand_add_prflxwhen a remote candidate cannot be found.prio_prflxdown from the main STUN message handler intohandle_stun_lite.