Skip to content

fix(bias_steps): Fix polarity issue in _fit_tau_effs #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ykyohei merged 1 commit into from
Sep 24, 2026
Merged

fix(bias_steps): Fix polarity issue in _fit_tau_effs #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sodetlib/operations/bias_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,10 +782,17 @@ def _fit_tau_effs(self, tmin=None, weight_exp=0.3):
if not len(ts[~np.isnan(ts)]):
continue
for rc in rcs:
# Here, the polarity of resp is aligned to dIbias
# and the offset is adjusted to be zero at the end.
# Immediately after the bias increase, temperature of TES
# cannot follow the change and the resistance is the same.
# In this regime, resp increases in electrical time constant.
# Then, as the temperature and resistance gradually rise,
# resp decreases in thermal time constant, tau_eff.
# We first find the peak and fit the latter part.
resp = self.mean_resp[rc]
if tmin is None:
sgn = self.polarity[rc] * -1
tmin_m = sgn*resp > 0.9 * np.nanmax(sgn*resp)
tmin_m = resp > 0.9 * np.nanmax(resp)
if not tmin_m.any():
continue
fit_tmin = np.max((0, ts[tmin_m][-1]))
Expand Down