fix(bias_steps): Fix polarity issue in _fit_tau_effs - #521
Merged
Merged
Conversation
ykyohei
reviewed
Sep 16, 2026
ykyohei
left a comment
ykyohei
left a comment
There was a problem hiding this comment.
Thanks, this change looks good to me as I mentioned in #518
The procedure to apply this seems to be
- release the new tag of sodetlib
- update sodetlib version of pysmurf controller agent
- update pysmurf controller agents at site
Is it okay to do these? @dpdutcher
I can help apply the fix retroactively and create new det_cal metadata.
Member
Author
|
I want to fix #522 as well... |
dpdutcher
approved these changes
Sep 17, 2026
dpdutcher
left a comment
dpdutcher
left a comment
Collaborator
There was a problem hiding this comment.
Hi sorry for slow response, Github messages were still going to my old email.
I see in the linked issue that you tested these changes retroactively and found them to not negatively affect other results, so I'll approve.
ykyohei
approved these changes
Sep 24, 2026
ykyohei
left a comment
ykyohei
left a comment
There was a problem hiding this comment.
I agree 522 is good to fix but it needs some more work to deploy.
Let's fix one by one. I'll merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #518