Repository navigation
Conversation
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2037 +/- ##
==========================================
+ Coverage 34.81% 34.92% +0.10%
==========================================
Files 127 127
Lines 6870 6895 +25
==========================================
+ Hits 2392 2408 +16
- Misses 4478 4487 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Meredith Lancaster <malancas@users.noreply.github.com>
Member
|
@malancas can you rebase? |
Member
Signed-off-by: Meredith Lancaster <malancas@users.noreply.github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
malancas
changed the title
malancas
changed the title
malancas
commented
Nov 9, 2026
| "github.com/sigstore/sigstore-go/pkg/root" | ||
| "github.com/sigstore/sigstore/pkg/cryptoutils" | ||
| "github.com/sigstore/sigstore/pkg/fulcioroots" | ||
| "github.com/sigstore/sigstore/pkg/fulcioroots" //nolint:staticcheck |
Contributor
Author
There was a problem hiding this comment.
Replacing github.com/sigstore/sigstore/pkg/fulcioroots with sigstore-go functions is more involved. I plan to replace this in a follow up PR and am adding this linting ignore rule temporarily.
malancas
commented
Nov 9, 2026
| "github.com/sigstore/sigstore/pkg/fulcioroots" | ||
| "github.com/sigstore/sigstore/pkg/tuf" | ||
| "github.com/sigstore/sigstore/pkg/fulcioroots" //nolint:staticcheck | ||
| "github.com/sigstore/sigstore/pkg/tuf" //nolint:staticcheck |
Contributor
Author
There was a problem hiding this comment.
I also plan to remove github.com/sigstore/sigstore/pkg/tuf in a follow up.
…y target fetching Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
malancas
changed the title
malancas
commented
Nov 9, 2026
| logging.FromContext(ctx).Infof("Initializing TUF root from %s => %s", *tufRoot, *tufMirror) | ||
| if err := tuf.Initialize(ctx, *tufMirror, tufRootBytes); err != nil { | ||
| // Legacy Fulcio and Rekor loaders still use their own TUF singleton. | ||
| if err := legacytuf.Initialize(ctx, *tufMirror, tufRootBytes); err != nil { |
Contributor
Author
There was a problem hiding this comment.
Because the deprecated sigstore/sigstore Fulcio and Rekor code will be removed in a follow up, we need to temporarily preserve the legacy client.
malancas
marked this pull request as ready for review
November 9, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces
sigstore/sigstorewithsigstore/sigstore-gowhen building a TUF root and client. The deprecatedgithub.com/sigstore/sigstore/pkg/fulciorootspackage will be replaced withsigstore-goin a follow up pull request since that work is more involved.This pull request will be followed by at least two others for replacing the deprecated sigstore/sigstore Fulcio and Rekor functionality.
Release Note
Documentation