Repository navigation
deps: bump knative.dev/pkg to fix OTel schema URL conflict panic - #2044
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2044 +/- ##
=======================================
Coverage 34.81% 34.81%
=======================================
Files 127 127
Lines 6870 6870
=======================================
Hits 2392 2392
Misses 4478 4478 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Any bump of go.opentelemetry.io/otel/sdk past v1.44 makes the webhook crash on startup: panic: conflicting Schema URL: https://opentelemetry.io/schemas/1.43.0 and https://opentelemetry.io/schemas/1.41.0 knative.dev/pkg/observability/resource.Default knative.dev/pkg builds its resource with semconv v1.41.0 while newer otel SDKs use v1.43.0. knative.dev/pkg main has moved to semconv v1.43.0, so bump it (which also pulls otel to v1.47.0). The new knative.dev/pkg marks ConditionManager.MarkFalse as printf-like, so pass the message through "%s" instead of as the format string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
force-pushed
the
fix-knative-otel-semconv
branch
from
November 9, 2026 13:48
9588c06 to
6dfac7e
Compare
bobcallaway
approved these changes
Nov 9, 2026
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xref: #2018 #2019 #2020 #2021 #2042
Summary
Bumping
go.opentelemetry.io/otel/sdkpast v1.44 makes the policy-controller webhook crash on startup, which is why every e2e job fails on the open otel and minor-patch dependabot PRs:The pinned
knative.dev/pkgmerges its resource using semconv v1.41.0, while newer otel SDKs use v1.43.0.knative.dev/pkgmain has moved to semconv v1.43.0, so this bumps it. That also pulls otel to v1.47.0 and k8s to v0.36.5.The new
knative.dev/pkgmarksConditionManager.MarkFalseas printf-like, sogo vet/lint flag passingmsgas the format string. Those calls now use"%s", msg, which also stops a%in an error message from being mangled.Testing
resource.Default(...)no longer panics and returns schema1.43.0.go build ./...,go vet,golangci-lint run(0 issues), and./hack/update-codegen.sh(no diff) pass.go test ./...passes exceptpkg/policy, which hangs fetching the public TUF root from my machine. It hangs the same way on main, so it's environmental.Not covered here
setup-kinddropsv1.33.x. Test e2e against supported Kubernetes versions where possible #2040 already updates the k8s matrix andsetup-kind.sigstore/sigstorebump deprecatespkg/tufandfulcioroots. Begin to replace deprecated sigstore/sigstore implemented TUF client implementation with sigstore/sigstore-go #2037 (migrate to sigstore-go) addresses that.🤖 Generated with Claude Code