[fallenbagel]

Description

TypeORM entities and subscribers load from directory globs over every .ts file under server/entity and server/subscriber. While it is harmless today since neither folder has a test file, but drop one in and requiring it runs the module body, which calls setupTestDb() again. That registers a second root before and beforeEach after the runner already built its tree, so two schema rebuilds collide on the single in-memory sqlite connection: "cannot start a transaction within a transaction," every test cancelled, nothing in the failure pointing at the actual file or the actual error.

Production is worse. build:server compiles every .ts under server, test files included, and production loads dist/entity/**/*.js, so a compiled test file there runs its module body at boot. seedTestDb calls dropDatabase() on the shared dataSource with no check on which database it's pointing at, then rebuilds the schema and seeds admin@seerr.dev with Permission.ADMIN and a hardcoded bcrypt hash. I confirmed this against a throwaway sqlite file under NODE_ENV=production and it dropped a table I'd put there first, rebuilt 15 tables, and left those two accounts behind.

Important

No released version is affected. No tag ships a test file under dist/entity or dist/subscriber, so there's nothing to fix or disclose.

Now, seedTestDb and resetTestDb refuse to run unless NODE_ENV is test. cypress:prepare, now opts in via seedTestDb({ allowOutsideTest: true }). This deny-unless-permitted was added because a plain node process with no NODE_ENV set resolves to devConfig against config/db/db.sqlite3, someone's real database if they're running from source.

In addition, build:server points at a new server/tsconfig.build.json that excludes *.test.ts, so dist stops shipping the compiled test files it currently produces. Config was separated because because typecheck:server is the only thing type checking those files, and the root tsconfig covers src only and excluding at the base would've silently dropped the files from CI.

Lastly, typeORM gets the entity and subscriber classes directly instead of globs, which also drops the duplicated ts/js patterns across the five config variants. Narrowing the globs to skip *.test.ts would achieve the same thing provided the files named are named that way in directories and a differently named test file, a helper, or a newly globbed directory brings the whole thing back. Classes mean nothing is matched by pattern, at the cost of a list to keep current, forget to add an entity and it throws EntityMetadataNotFoundError the first time its repository is used anyways. Much more safer this way. Migrations stay globbed.

How Has This Been Tested?

• Checked the dist if the test files were carried after build
• Checked if the tests still run
• Checked if entities and subscribers were properly loaded.

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Bug Fixes

  • Improved database configuration reliability across supported environments.
  • Added configurable PostgreSQL connection timeouts, defaulting to 30 seconds.
  • Prevented accidental test database seeding or resets outside test environments.

• Build

  • Updated server builds to exclude test files from production compilation.

• Tests

  • Added coverage verifying safeguards against unsafe test database operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0002995b-6a21-4eb8-aff0-b998dc72b1a2

📥 Commits

Reviewing files that changed from the base of the PR and between 4d414ba and da2175a.

📒 Files selected for processing (1)

• package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds explicit server build settings, shared database entity and subscriber registration, configurable PostgreSQL connection timeouts, and safeguards for test database mutations outside test mode.

Changes

Database build and test safety

Layer / File(s)	Summary
Explicit database build and registration server/tsconfig.build.json, server/datasource.ts, package.json	The server build excludes test files. Data sources use shared entity and subscriber arrays. PostgreSQL configurations read DB_CONNECT_TIMEOUT_MS with a 30-second default. node-cache is removed.
Test database environment guard server/utils/seedTestDb.ts, server/scripts/prepareTestDb.ts, server/utils/seedTestDb.test.ts	Seeding and resetting reject execution outside NODE_ENV=test unless seeding receives allowOutsideTest. Tests verify the rejection behavior and restore the environment.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to da217

The change explicitly registers datasource entities and subscribers, excludes test files from server builds, and guards destructive test-database operations outside test mode; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: 0xsysr3ll, danshilm

Sequence Diagram(s)

sequenceDiagram
  participant prepareTestDb
  participant seedTestDb
  participant assertTestDatabase
  prepareTestDb->>seedTestDb: Call with allowOutsideTest: true
  seedTestDb->>assertTestDatabase: Validate runtime environment
  assertTestDatabase-->>seedTestDb: Allow seeding or throw
  seedTestDb-->>prepareTestDb: Complete database preparation

Loading

Poem

A rabbit checks the database gate

Test mode opens; production must wait
Shared entities hop into line
Timeouts tick for thirty seconds fine
Safe seeds now burrow straight

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary datasource change: explicit registration of entities and subscribers instead of filesystem globs.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR hardens and stabilizes the server’s test database setup and TypeORM entity/subscriber loading, while keeping server builds free of test-only files.

Changes:

• Added an explicit NODE_ENV === 'test' guard to prevent accidental destructive seeding/resets, with an opt-in escape hatch for tooling.
• Replaced TypeORM glob-based entity/subscriber discovery with explicit imports to ensure consistent entity loading.
• Updated the server build config to exclude *.test.ts and adjusted build:server to use the new build tsconfig.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
server/utils/seedTestDb.ts	Adds a safety guard for destructive test DB operations and an opt-in override.
server/utils/seedTestDb.test.ts	Adds unit tests for the test DB guard behavior.
server/tsconfig.build.json	New build tsconfig excluding *.test.ts from server compilation output.
server/scripts/prepareTestDb.ts	Opts into seeding outside NODE_ENV=test for Cypress preparation.
server/datasource.ts	Switches entity/subscriber loading from glob strings to explicit imports/arrays.
package.json	Updates build:server to use server/tsconfig.build.json (and matching tsc-alias).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cypress]

seerr    Run #3659

Run Properties:   Passed #3659  •  0f79ee663c: fix(datasource): register entities and subscribers explicitly (#3375)

Project	seerr
Branch Review	develop
Run status	Passed #3659
Run duration	02m 13s
Commit	0f79ee663c: fix(datasource): register entities and subscribers explicitly (#3375)
Committer	fallenbagel
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	1
Pending	0
Skipped	0
Passing	33
View all changes introduced in this branch ↗︎

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/components/Settings/SettingsNetwork/index.tsx:179

• checkUpdateAvailable=false may not actually disable update checks because Express query values are strings; on the server, /status treats any defined value as checkUpdate and then uses if (checkUpdate), so the string 'false' is truthy. This means the request keyed by this URL can still trigger GitHub update checking (and related rate limiting). Consider parsing req.query.checkUpdateAvailable as a real boolean server-side (e.g., === 'true'), or change the client/server contract to use a falsy value.

              // the key StatusChecker polls on, so the restart modal shows at once
              mutate('/api/v1/status?checkUpdateAvailable=false');

server/utils/seedTestDb.ts:27

• The new guard error message says it "drops every table", but seedTestDb can be called with preserveDb: true and then it won’t drop the DB. Also, including the current NODE_ENV value would make the failure easier to diagnose in CI/automation.

  throw new Error(
    `Refusing to ${operation} while NODE_ENV is not test: this drops every table and seeds accounts with a known password.`
  );

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.