[fallenbagel]

Description

Forgot to test PGSql when testing #3375 which replaced the entity globs with static imports, which hoist above the isPgsql declaration at the bottom of datasouce.ts. Entities therefore loaded while isPgsql was still undefined, and since resolveDbType runs as a decorator argument at class-definition time, every datatime column resolved to the sqlite type and Postgres refused to start. Moved isPgsql into an import-free module so reading it never depends on datasource.ts having finished evaluating.

• Fixes Regression in #3375: Postgres startup fails with DataTypeNotSupportedError on IssueComment.createdAt #3448

How Has This Been Tested?

• Tested on sqlite and postgres.

Screenshots / Logs (if applicable)

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

Summary by CodeRabbit

• Refactor
  • Centralized PostgreSQL database detection for more consistent database configuration.
  • Improved internal initialization reliability without changing application behavior.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 103096db-96cc-4764-9ad7-9d3d79789e95

📥 Commits

Reviewing files that changed from the base of the PR and between da4b555 and afb5b6e.

📒 Files selected for processing (4)

• server/datasource.ts
• server/index.ts
• server/utils/DbColumnHelper.ts
• server/utils/dbType.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The isPgsql environment check moves to an import-free utility. Datasource configuration, server startup, and database column handling now import the shared constant from that utility.

Changes

Database type detection centralization

Layer / File(s)	Summary
Import-safe database type utility server/utils/dbType.ts, server/utils/DbColumnHelper.ts	Adds the import-free isPgsql constant and updates DbColumnHelper to use it.
Datasource and startup imports server/datasource.ts, server/index.ts	Updates datasource configuration and server startup to import isPgsql from server/utils/dbType.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to afb5b

This localized import change resolves PostgreSQL timestamp initialization without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: 0xsysr3ll, danshilm

Poem

A rabbit found a circular trail
And moved the flag to a simpler rail
The columns now know the database type
Startup imports the value right
PostgreSQL hops past the failing night

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the datasource import-cycle fix and the PostgreSQL timestamp failure it addresses. The wording contains a minor typo but remains understandable and related to the main cha…
Linked Issues check	✅ Passed	The changes satisfy issue #3448 by moving isPgsql to an import-free utility module and updating all affected imports. This breaks the circular dependency and allows PostgreSQL datetime columns to reso…
Out of Scope Changes check	✅ Passed	All changes are limited to relocating isPgsql and updating its imports. They directly support the PostgreSQL startup fix described in issue #3448.

Full details: Title check

Explanation

The title clearly identifies the datasource import-cycle fix and the PostgreSQL timestamp failure it addresses. The wording contains a minor typo but remains understandable and related to the main change.

Full details: Linked Issues check

Explanation

The changes satisfy issue #3448 by moving isPgsql to an import-free utility module and updating all affected imports. This breaks the circular dependency and allows PostgreSQL datetime columns to resolve correctly during entity evaluation.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}