Repository navigation
Conversation
…owns its program clang-tidy's ratchet fails on main, and so on every pull request, with two findings in dm/gfx/tests/t_geometry_hazards.m that the baseline does not have. One is clang-analyzer-nullability.NullablePassedToNonnull: the readback buffer from newBufferWithLength, which may be nil, goes straight to the blit. The other is clang-analyzer-osx.cocoa.RetainCount: a potential leak of the program 'pr'. The test now fails its check and resets when the readback buffer was not made. The leak is not one: serial_put hands pr to g_by_serial (its CFBridgingRetain), which owns it. A NOLINT says so, on the line where the analyzer reports the leak (the posix_memalign line after serial_put). Checked: on seedds#957's branch the same two changes took the ratchet back to the baseline (clang-tidy passed in CI), and t_geometry_hazards passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MKLOL
pushed a commit
to MKLOL/nxnative
that referenced
this pull request
Nov 2, 2026
…ersed The earlier commits converted RGBA4 through a representation layer of its own for format views, integer images, scaled copies and 3D mirrors: cases no game is known to reach. RGBA4 now uses the existing packed-format crossings (uploads, buffer <-> texture copies, ReadTexels, storage readbacks, and the in-place mapping of linear and buffer textures), reversing the four nibbles where the RGB565 family exchanges red and blue. Same-size views in another format keep the RGB565 family's documented limit. Main's own clang-tidy fixture findings are left to their pull requests (seedds#958, seedds#959, seedds#979). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6nJ82QTpmojw3kPgmTLxZ
MKLOL
pushed a commit
to MKLOL/nxnative
that referenced
this pull request
Nov 2, 2026
…ersed The earlier commits converted RGBA4 through a representation layer of its own for format views, integer images, scaled copies and 3D mirrors: cases no game is known to reach. RGBA4 now uses the existing packed-format crossings (uploads, buffer <-> texture copies, ReadTexels, storage readbacks, and the in-place mapping of linear and buffer textures), reversing the four nibbles where the RGB565 family exchanges red and blue. Same-size views in another format keep the RGB565 family's documented limit. Main's own clang-tidy fixture findings are left to their pull requests (seedds#958, seedds#959, seedds#979). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
clang-tidy's ratchet fails on
main, and so on every pull request (for example this run on #974, which doesn't touch the file). It reports two findings indm/gfx/tests/t_geometry_hazards.mthat the baseline doesn't have:clang-analyzer-nullability.NullablePassedToNonnull: the readback buffer, whichnewBufferWithLengthmay return as nil, goes straight to the blit. The test now fails its check and resets when the buffer wasn't made.clang-analyzer-osx.cocoa.RetainCount: a potential leak of the programpr. It isn't one:serial_puthandsprtog_by_serial(itsCFBridgingRetain), which owns it. ANOLINTsays so, on the line where the analyzer reports the leak.These are the same two changes that brought #957's clang-tidy back to the baseline.
Checked
t_geometry_hazardspasses on this branch, 57 checks (M3 Pro, macOS 27.0.1). clang-tidy isn't installed here; on Fire Emblem Fortune's Weave plays on the Mac #957 the same lines passed CI's ratchet.Docs
🤖 Generated with Claude Code