Repository navigation
Reject incompatible thread-slot rewrites on Apple hosts - #2
Draft
thehobbit85 wants to merge 1 commit into
Draft
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Android module can reach the Apple loader with a valid layout header. The two native hosts read thread state through different ARM registers. An attempt to run the Android rewrite on Apple previously passed the layout check.
Reject a nonzero
TP_SLOTwhen reading the module header, before mapping it. Apple modules produced before this check still load. The marker matches the Android fork.Checked
0100633007D48000. All 11 documentation tests passed.First PR in the native-port stack. The offline Android rewriter builds on this guard. Merge this PR first.
Regression report
regress.py check (full): PASS
Baseline
fork/main65501fb, candidatecodex/port-01-rewrite-abi09472c2; Apple M2 Max, macOS 26.6, Xcode 27.0; 1054.9 s0100F43008C44000LegendsZA
0100F43008C44000: PASSCI on the base
The clang-tidy job reports a nullable readback buffer and a retained program in
dm/gfx/tests/t_geometry_hazards.m. This PR does not change that fixture. Upstream PR 979 addresses those findings separately.